From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53842 invoked by alias); 31 Mar 2015 17:01:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53799 invoked by uid 89); 31 Mar 2015 17:01:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 17:01:23 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id D8E54340861; Tue, 31 Mar 2015 17:01:20 +0000 (UTC) Date: Tue, 31 Mar 2015 17:01:00 -0000 From: Mike Frysinger To: "H.J. Lu" Cc: Binutils , GDB Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd Message-ID: <20150331170122.GJ25224@vapier> Mail-Followup-To: "H.J. Lu" , Binutils , GDB References: <20150326155711.GA10088@gmail.com> <20150331061337.GA30996@vapier> <20150331164107.GI25224@vapier> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nrXiCraHbXeog9mY" Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01059.txt.bz2 --nrXiCraHbXeog9mY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1790 On 31 Mar 2015 09:56, H.J. Lu wrote: > On Tue, Mar 31, 2015 at 9:41 AM, Mike Frysinger wrote: > > On 31 Mar 2015 03:10, H.J. Lu wrote: > >> On Mon, Mar 30, 2015 at 11:13 PM, Mike Frysinger wrote: > >> > On 26 Mar 2015 08:57, H.J. Lu wrote: > >> >> --- a/bfd/configure.ac > >> >> +++ b/bfd/configure.ac > >> >> > >> >> -# Link in zlib if we can. This allows us to read compressed debug= sections. > >> >> -# This is used only by compress.c. > >> >> -AM_ZLIB > >> >> +# Use the system's zlib library. > >> >> +zlibdir=3D-L../zlib > >> >> +zlibinc=3D"-I\$(srcdir)/../zlib" > >> >> +AC_ARG_WITH(system-zlib, > >> >> +[AS_HELP_STRING([--with-system-zlib], [use installed libz])], > >> >> +zlibdir=3D > >> >> +zlibinc=3D > >> >> +) > >> > > >> > this is wrong. the 3rd arg is whether the option was specified, not= that the > >> > option was disabled. you need to check $withval is equal to "no" (o= r not equal > >> > to "yes"). > >> > >> That is what gcc/configure.ac has and it works for me. > > > > then gcc/configure.ac is also broken. whether "it works for me" is > > irrelevant -- simply read the code and you'll see it's wrong. if you > > pass --without-system-zlib the code wrongly behaves as if you passed > > --with-system-zlib. > > > > i mention this because it is breaking my test builds. not that that > > really matters -- the code is clearly incorrect. >=20 > We should fix zlib.m4 and use it in gcc/configure.ac. sure; i await your patches ;). i'm not trying to point fingers here for pointing's sake -- binutils & gdb were working before and now they're broke= n, and they broke due to the zlib patches you merged. so i think it's reasona= ble to expect you to drive further fixes (probably across gcc) even though the = bug=20 has existed in gcc for sometime. -mike --nrXiCraHbXeog9mY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVGtLiAAoJEEFjO5/oN/WBiIoP/iOfPOESgSL5gpZaHZZaDTpz Owv44V5t+4Mxu2JEeScOog/XK+RTUvRPv1hUavL1G2duOO+q/q8qC3/+Wh5/H5Oz GdF+fmKMYA2zgJFoJQfMg/NrpmvCVG8ELObcLs+SblrZRhDUxDTQzqoQIhsBGaxT 6Mosba8VcrQnZmemqOhXh80+YgYFwIS4+RiONEx5LcAZghwi2X0fMGnKCnsHKXvV hflxaIwwC2d0hR0hWzgWMeIMPNmnYRJyjeWlY99zIA0yWxC8uU6NEwKkjDvvDpIc WSBkaQhzQruX1lTb1LeqDT2UI1u0I5xzKKDZX+3QnmS0o+1QUTvOIJMFtYqBPAYb C1bDSDNlTXvsCKX9TU08xDc6VqfGefwwRLfx6ObOmNrEnX0uqItJzG9lyRcwFXWF 0R8e1Ce72dAqcgO/uPRR26Adb81o2KR1vWRv9Tsu6cpDxq53XgCap4wHEhASWB9P vVGupSWiVQLvKjtvHOJHcCTQLTopy/OnP9Nw+vGHA1eEWhziVqrPO7gZdWwZ5aBW XPUR9WTXAtlshpzckEQULVA0gfSGbxTYtj0APf9zlK/ih7dKDy12tvt3mAn/8g9l xoj1ukmxaLvhNcRWocBt8+LAboWA3tWSbSjN17w8TvJ1kpotT9nKc+S6tVvrnBNR OKhmvlpLsjdL9cD6r6F6 =Gcpa -----END PGP SIGNATURE----- --nrXiCraHbXeog9mY--