From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121359-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 43501 invoked by alias); 31 Mar 2015 06:13:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 43475 invoked by uid 89); 31 Mar 2015 06:13:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: smtp.gentoo.org
Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 06:13:38 +0000
Received: from vapier (localhost [127.0.0.1])	by smtp.gentoo.org (Postfix) with SMTP id 041B73408E0;	Tue, 31 Mar 2015 06:13:35 +0000 (UTC)
Date: Tue, 31 Mar 2015 06:13:00 -0000
From: Mike Frysinger <vapier@gentoo.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd
Message-ID: <20150331061337.GA30996@vapier>
Mail-Followup-To: "H.J. Lu" <hjl.tools@gmail.com>, binutils@sourceware.org,	GDB <gdb-patches@sourceware.org>
References: <20150326155711.GA10088@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU"
Content-Disposition: inline
In-Reply-To: <20150326155711.GA10088@gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg01023.txt.bz2


--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-length: 633

On 26 Mar 2015 08:57, H.J. Lu wrote:
> --- a/bfd/configure.ac
> +++ b/bfd/configure.ac
>=20=20
> -# Link in zlib if we can.  This allows us to read compressed debug secti=
ons.
> -# This is used only by compress.c.
> -AM_ZLIB
> +# Use the system's zlib library.
> +zlibdir=3D-L../zlib
> +zlibinc=3D"-I\$(srcdir)/../zlib"
> +AC_ARG_WITH(system-zlib,
> +[AS_HELP_STRING([--with-system-zlib], [use installed libz])],
> +zlibdir=3D
> +zlibinc=3D
> +)

this is wrong.  the 3rd arg is whether the option was specified, not that t=
he=20
option was disabled.  you need to check $withval is equal to "no" (or not e=
qual=20
to "yes").
-mike

--azLHFNyN32YCQGCU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-length: 819

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVGjsRAAoJEEFjO5/oN/WBElQQAJoyGQ5aKsCGd59DPHnaol6a
nNju7k/TXlFNVh2dUo+/1v2sfzH3P0q/lbe9vredrXU7Ri2BDjI6/CyfiOLMUDYa
lCbfdPxNDMnGDY3+Xz6QuD12GwPLzTlUBiBQ2686GfziGo47NmycukO8NcfX0/Mq
srWAYfMbGZs/LcJffsaeOEcQfIRVPV3WTlSJhhnLkiHicM8TE8aWbTcHZkojCrzU
4Z7c0COW1Bx5ForBtmZyB12l5zl/EZum6Sg8wzWKpiXrl3PVOtj0ezFukYwrvkuf
i8kJdcn5cXELYj3dOhe3ZzHbNz2uoE26VMI84GU38Y2ng8MHQzvUi2ZMGE0O2oH5
AxEPUngEqeot5SuCzuIWr0VoKRfCZ9wTIBra9qADyVbiGRaU0SBBNfkPTOjWEOvK
+vt26b66ksJUrph2f3wOVdwLEPkJQyw+xOfykEwtjmmwNS/lAmRvSTk7CIGdVGfL
561d3oaE+O/GU99wPgE7YdikSkg6OmnUYlwsBW2Km+gx5ZsrqrfhuSqP+KwHI0Ky
TYrXc7kFf3HzxCBLUnDalsG9dKe81qfwQLzA2MyHY/XwBQUbQkaXj6M5qEPmrtn/
VJoaH2k1v4Vhu49gveQmzXAB3LX6UD62x6DtsvOLVfVuLJ3xkOJJTzzfXZ3oZIT6
JAl108oZ8gjnwqlM7y5/
=usjW
-----END PGP SIGNATURE-----

--azLHFNyN32YCQGCU--