From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107492 invoked by alias); 27 Mar 2015 07:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107483 invoked by uid 89); 27 Mar 2015 07:33:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Mar 2015 07:33:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2R7Xbdw005641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Mar 2015 03:33:37 -0400 Received: from host1.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2R7XYZl025779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 27 Mar 2015 03:33:36 -0400 Date: Fri, 27 Mar 2015 07:33:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com Subject: Re: [PATCH 4/4] compile: New 'compile print' Message-ID: <20150327073333.GA28529@host1.jankratochvil.net> References: <20150326205727.28223.54648.stgit@host1.jankratochvil.net> <20150326205752.28223.24230.stgit@host1.jankratochvil.net> <83iodmnc18.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83iodmnc18.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00881.txt.bz2 On Fri, 27 Mar 2015 08:18:43 +0100, Eli Zaretskii wrote: > I suggest a different name for this command. Unfortunately, "eval" is > already taken, but perhaps "parse" or "parse-eval"? Or maybe a new > switch to "print"? "compile print" sounds awkward and unintuitive to > me. FYI there is already "compile code" and "compile file". > > + add_cmd ("print", class_obscure, compile_print_command, > > + _("\ > > +Evaluate a EXPR with the compiler and print result.\n\ > > Suggest to drop the "a" part, it just makes this sentence harder to > read. OK, it will be changed upon check-in. > > +The expression may be specified in one line, e.g.:\n\ > > "on the same line as the command" sounds more clear to me. OK, it will be changed upon check-in. Thanks, Jan