Re: [PATCH 4/4] compile: New 'compile print'

Phil Muldoon
2015-03-27T10:20:35Z

On 27/03/15 09:56, Eli Zaretskii wrote:
>> Date: Fri, 27 Mar 2015 10:16:17 +0100
>> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>> Cc: Phil Muldoon <pmuldoon@redhat.com>, gdb-patches@sourceware.org
>>
>>> Can it include calls to standard functions? Can it call functions from
>>> libraries other than libc? What about functions defined by the inferior?
>>
q>> yes, yes (as long as the library is already DT_NEEDEDed or dlopen()ed by the
>> inferior), yes.
>
> Are you sure the last part (calling functions in the inferior) will
> work on all platforms? How does the GCC plugin know to resolve the
> address of the inferior's functions correctly? Won't it need some
> kind of import library on Windows?

Via the address translation oracle. This is no different from the
compile code/file mechanism that was reviewed and committed some
months ago. Does it work on all platforms? I can't answer that as I do
not have access to all platforms. Few people, I suspect, do. But this
is pretty much true of every patch submitted in GDB. But if it doesn't
work then the error handling mechanisms of GDB and GCC plugin should
handle it. Just like any other platform dependent bugs. As always if
people on those platforms file bugs, we will always gladly help fix
them.

On the issue of compile print and preconceived notions by users
regarding the utility of the function, then it is a documentation
issue. Your assertion of what the user "might think" can easily be
remedied by documentation fixes to the help command and/or the
manual. This will help correct any previous notions, and guide them to
what they should think of the command.

Other than the edits you have suggested (thank you for those!) do you
have any additional documentation edits that might help to address the
preconceived notions the user might have?

Cheers

Phil