From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5449 invoked by alias); 24 Mar 2015 04:18:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5439 invoked by uid 89); 24 Mar 2015 04:18:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Mar 2015 04:18:58 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id C2C33340936; Tue, 24 Mar 2015 04:18:55 +0000 (UTC) Date: Tue, 24 Mar 2015 04:18:00 -0000 From: Mike Frysinger To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: [RFC 0/4] Fix recent sim/*/config.in fallout: frv, m32r, sh64, iq2000 Message-ID: <20150324041856.GC10761@vapier> Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <201408200428.s7K4SNpt031643@ignucius.se.axis.com> <201408230313.s7N3DFps018785@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J" Content-Disposition: inline In-Reply-To: <201408230313.s7N3DFps018785@ignucius.se.axis.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00770.txt.bz2 --Izn7cH1Com+I3R9J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2275 On 23 Aug 2014 05:13, Hans-Peter Nilsson wrote: > From: Hans-Peter Nilsson > > Recently, a change requiring -ldl due to bfd plugin default changing > > from off to on, spread throughout the generated configury files, for > > simulators as well as gdb. In that process, sim/*/config.in for the > > sims below was regenerated for the first time since 2012. This had > > build-breaking fallouts for some simulator showing bloopers in changes > > from around 2013-03-23, attempts enabling sim-hardware and > > dv-sockser.o. Here's my take on fixing that: let's return to the > > state before those attempts. This is a request-for-comments, I'll > > commit this in a few days unless someone has a better idea, one that > > lets these simulators build *without* --{enable,disable} options and > > where committing this would still not be an incremental improvement. >=20 > Now committed. I'll stop here, noting that possible further cleanups > would be to fix the buggy SIM_AC_OPTION_HARDWARE and decouple the > prerequisites for dv-sockser.o from the act of actually enabling it > (e.g. the now combined effect of HAVE_DV_SOCKSER). Please also, if > you consider "re-enabling" simulated hardware for these sims, first > investigate whether all the wires and plumbing is in place for it to > actually make a difference in function for the particular sim. Also, > test-cases for the enabled simulated hardware would be helpful, even a > simple "hello, world" to a simulated serial port. i've finished landing a series of changes into master that can be summarize= d: - clean up dv-sockser code to centralize its enabled/disabled logic - let the common code handle building of dv-sockser all the time (sans min= gw) - fix bugs around SIM_AC_OPTION_HARDWARE default enable - delete the broken uart code from frv devices that leads me back to this patch series. there's no longer a need to disab= le hw in these sims by default, so i've somewhat reverted these changes by set= ting=20 the default to "yes" for them. testcases would certainly be nice, but i have no idea how to write ones for= =20 these ports. i'll be pestering people in the future when they make updates= to=20 specific arches, and i'll be rejecting new sims that lack any tests. -mike --Izn7cH1Com+I3R9J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVEOWwAAoJEEFjO5/oN/WBueIP/RAlyLaiaNOWz4YLI6wUO9ML 1t+K7sTLi0ktONPRElyEqb+n5oahAXcvq6Wc7mlkfMu/FaC5BZKG8oFa3ftTzkGo FeqW9PPMUnNycbg6Vn1vhrhkPPTewcisuGJkpopMr7v/oAsslMb+TV1TsATnWmYH DSVMOqBPu2QiA2Yrg9+Tu613uJKogWMODKWaGFInmZhIvlYi03/IPdGzMqsJHrnG bbbZ2pC3aTdVTnzCU5kaTpqMVBjmSP5tDWvpaCPOk+LQgrBD7WunTOzakU4Rb2tB 3zELRFgneb75BPZBHjrr5f1PpcfdaKLeK4WOQsSW33Fjt971gNOCgJ3kkmGUhBIo y/SsuB8pf1vxhKEiyKgdrURRPFX/bdqvYjkfgQMpb07D9VwhhYBHjErj9+SXjl4y xm1mTqXNk0BfgazldCNYRY2oS1VatY5nhjA7t32FSZPJrmlNxC75TSOCsZzClInI gbJsEUCczfAhB3N2LKbhcZRUsqwtJO8BqSuZiRCanzyp48bV0RTUVMznzR9Hnhl2 EAB1uq4UxOlWON6G/01drCndmy94ijlmlWmeHZqOmFJ3L3fQpcrOSD+8kE1xy7E8 0fNiQ9B/TmOQsXytiwRERCbu7cdeqF4BebyUldFIkY5QeUPjseIE1rM60X+hAXad 4FYqMtA+xHNWXD9ImqL9 =/B1I -----END PGP SIGNATURE----- --Izn7cH1Com+I3R9J--