> Updated patch is attached. Thanks! I noticed that there was still a slight indentation error in the calls to internal_warning, so I set about to fix those before committing the patch for you. That's when I noticed that the ChangeLog entries would not apply, and this, combined with enhancing a bit the revision log to include that ChangeLog info, distracted me enough that I forgot to fix the indentation issues! So, attached is: first, the patch that you sent, with the revision log a little augmented to make it a little more descriptive about what the patch brings in; second, the indentation fixes, applied separately, unfortunately. gdb/ChangeLog: * ser-mingw.c (ser_windows_setparity): Fix indentation. * ser-unix.c (hardwire_setparity): Likewise. I pushed the patch for you because I suspect you do not have write permissions in GDB yet, and also to minimize the ping-pong effect. I think you've worked hard on cleaning that patch up already! If you think you might have other changes you'd like to contribute, it might make sense for you to get write-after-approval privileges. If you are interested, send me a private email and I'll get you started (let me know if you have a sourceware.org account already or not). Thanks again for the patch! -- Joel