From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32203 invoked by alias); 23 Mar 2015 17:08:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32193 invoked by uid 89); 23 Mar 2015 17:08:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Mar 2015 17:08:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C1A70AC7AB for ; Mon, 23 Mar 2015 17:08:34 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2NH8UNC023174 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 23 Mar 2015 13:08:33 -0400 Date: Mon, 23 Mar 2015 17:08:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Kai Tietz , gdb-patches@sourceware.org, Corinna Vinschen , Nicholas Clifton Subject: Re: [patch 1/2] mingw: update gnulib: prepare the sources Message-ID: <20150323170830.GA8493@host1.jankratochvil.net> References: <20141222221229.GA30575@host2.jankratochvil.net> <108241234.1319759.1419335690162.JavaMail.zimbra@redhat.com> <20141224222045.GA30482@host2.jankratochvil.net> <551044A0.9070607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551044A0.9070607@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00726.txt.bz2 On Mon, 23 Mar 2015 17:51:44 +0100, Pedro Alves wrote: > --- /dev/null > +++ b/gdb/common/gdb_sys_time.h > @@ -0,0 +1,38 @@ [...] > +#ifndef GDB_SYS_TIME_H > +#define GDB_SYS_TIME_H > + > +#include > + > +/* On MinGW-w64, gnulib's sys/time.h replaces 'struct timeval' and > + gettimeofday with versions that support 64-bit time_t, for POSIX > + compliance. However, the gettimeofday replacement does not ever > + return time_t values larger than 31-bit, as it simply returns the > + system's gettimeofday's (signed) 32-bit result as (signed) 64-bit. > + Because we don't really need the POSIX compliance, and it ends up > + causing conflicts with other libraries we use that don't use gnulib > + and thus work with the native struct timeval, such as Winsock2's > + native 'select' and libiberty, simply undefine away gnulib's > + replacements. */ > +#if GNULIB_defined_struct_timeval > +# undef timeval > +# undef gettimeofday > +#endif > + > +#endif /* #ifndef GDB_SYS_TIME_H */ With this header file used for GDB's sources aren't gnulib's .c files compiled with incompatible ABI? Jan