From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99863 invoked by alias); 20 Mar 2015 15:40:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99851 invoked by uid 89); 20 Mar 2015 15:40:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Mar 2015 15:40:31 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id D62FC340BC2; Fri, 20 Mar 2015 15:40:28 +0000 (UTC) Date: Fri, 20 Mar 2015 15:40:00 -0000 From: Mike Frysinger To: Nicholas Clifton Cc: dj@redhat.com, gdb-patches@sourceware.org Subject: Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral Message-ID: <20150320154028.GH11803@vapier> Mail-Followup-To: Nicholas Clifton , dj@redhat.com, gdb-patches@sourceware.org References: <87fv91nfy3.fsf@redhat.com> <20150319184231.GB4128@vapier> <550BF654.7070402@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D6z0c4W1rkZNF4Vu" Content-Disposition: inline In-Reply-To: <550BF654.7070402@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00629.txt.bz2 --D6z0c4W1rkZNF4Vu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 714 On 20 Mar 2015 10:28, Nicholas Clifton wrote: > >> Tested with no regressions on an rl78-elf toolchain. > > > > how do you really know when there are no sim tests ? >=20 > Because I use the sim to help run the gcc testsuite, and without this=20 > patch several gcc tests were failing due to errors from the sim about=20 > misaligned accesses to the MDB register. With this patch those failures= =20 > went away and no new failures were introduced. Hence I felt confident=20 > that the patch was good. OK. it would be nice if there were at least one minor sim test though. it's dirt simple to add one written in just assembly ... i have found directed sim tests to be better than gcc in the long run. -mike --D6z0c4W1rkZNF4Vu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVDD9sAAoJEEFjO5/oN/WBQGwQAIHx9Tx6pJjTiqZ2/7fMO9uG /hOygSAgt3ROJG68TEAAIcaAcnTaBdomtBCxP7UCJKl2zxmSplsSVr/M/8tDCvY4 pCoh8EbXIstJin3+/O+mEaibEoNr0DanzpzjYyBYe2+l6ymqFqs8Pi6DsQTvbO2D NofbHUh/p2500wxCm5cseD5rVS4T16VDER2+srdRhUDh/zfzEOceREWA8E14YsMk 3uXJwTWfBg2udSZxWod9Z4tnjCsnB7LWaE1ta6O3EnRSWAoPmAJpZy3WhJVPkTrL ZTM9za/zWPCG6702Aw+5c5PY/s5zloIGZKZCGXYkmi1369PtSYyC6Bgi3zcB9BnI KVtfpOdrwZHtfM9muaC4Dxrc2UvClslyfp2xSJ/KRGeBIfjhFr2XM7LuyblNfToV 8F7gkeaMS+4w1yixHYVqoq3Ud49nF611Wv7jnhhesJYR15bTSjsRnYZcslHFEiGF A1EAaJbv1w7oHp14XeeStJILYMbWWJBeayPJ6/yylWet+RiTLv94XvHJnOrSmYAn 2NVZzbG0AHe6pR8pQ8k71JNjwYHGiJNFfEUexXqikminczofVd/UysjpzwFr4ecz n2vMxUc/C8m5tDeV1kqYNrnelXK7mGcBJ/ZsFrPS61U6qDydEetB9G1yZtR0uxyc 45kD2OgOpeBkRd4iew3u =dfw+ -----END PGP SIGNATURE----- --D6z0c4W1rkZNF4Vu--