Re: [PATCH v2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902)

Sergio Durigan Junior
2015-03-18T19:39:59Z

On Wednesday, March 18 2015, Pedro Alves wrote:

> On 03/16/2015 11:53 PM, Sergio Durigan Junior wrote:
>
>> To summarize: I decided to change this part of the code, and make GDB
>> actually ignore (i.e., return 0) mappings marked as UNMODIFIED. After
>> all, as explained above, this is what Linux does.
>
> I can't tell whether we'll still need the UNKNOWN state after that,
> but offhand, if a mapping isn't supposed to be dumped, why not
> just skip calling the callback (gcore_create_callback)?

That is another option. Initially we would call gcore_create_callback
because at least the segment header should be created in the corefile;
however, as I mentioned before, Linux doesn't do that (therefore GDB
shouldn't too).

--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible