From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6976 invoked by alias); 11 Mar 2015 10:07:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6955 invoked by uid 89); 11 Mar 2015 10:07:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 11 Mar 2015 10:07:09 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2BA75b8030998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Mar 2015 06:07:06 -0400 Received: from blade.nx (ovpn-116-85.ams2.redhat.com [10.36.116.85]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2BA75s7019931; Wed, 11 Mar 2015 06:07:05 -0400 Received: by blade.nx (Postfix, from userid 1000) id 640F3265072; Wed, 11 Mar 2015 10:07:02 +0000 (GMT) Date: Wed, 11 Mar 2015 10:07:00 -0000 From: Gary Benson To: Michael Eager Cc: "gdb-patches@sourceware.org" , binutils Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb Message-ID: <20150311100702.GA3698@blade.nx> References: <54FF77D6.7010400@eagerm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FF77D6.7010400@eagerm.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00273.txt.bz2 Michael Eager wrote: > Add support to automatically unzip compressed executable and core > files. Files will be uncompressed into temporary directory (/tmp or > $TMPDIR) and are deleted when GDB exits. This should be transparent > to users, except for disk space requirements. The name of the > uncompressed file is mentioned, but all references to the file in > GDB messages is to the file which the user specified. ... > diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c > index 14d6324..b2c31fd 100644 > --- a/gdb/common/filestuff.c > +++ b/gdb/common/filestuff.c ... > +#ifndef GDBSERVER Please do not add GDBSERVER conditionals to gdb/common, I spent half a year removing them all. It looks like this code is only used by GDB, not gdbserver, so the fix is simple, just put the code somewhere GDB-specific. Thanks, Gary -- http://gbenson.net/