From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34466 invoked by alias); 5 Mar 2015 18:20:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34456 invoked by uid 89); 5 Mar 2015 18:20:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Mar 2015 18:20:33 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 2CA3134081F; Thu, 5 Mar 2015 18:20:31 +0000 (UTC) Date: Thu, 05 Mar 2015 18:20:00 -0000 From: Mike Frysinger To: Joel Brobecker Cc: Jiri Gaisler , gdb-patches@sourceware.org Subject: Re: [PATCH v3 10/14] sim/erc32: Add support for LEON3 processor emulation. Message-ID: <20150305182031.GB19311@vapier> Mail-Followup-To: Joel Brobecker , Jiri Gaisler , gdb-patches@sourceware.org References: <1425244244-27709-1-git-send-email-jiri@gaisler.se> <1425244244-27709-11-git-send-email-jiri@gaisler.se> <20150305173521.GB6730@vapier> <20150305174931.GA4604@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UHN/qo2QbUvPLonB" Content-Disposition: inline In-Reply-To: <20150305174931.GA4604@adacore.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00163.txt.bz2 --UHN/qo2QbUvPLonB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 406 On 05 Mar 2015 09:49, Joel Brobecker wrote: > > > + return(memory_read(addr, data, sz, ws)); > >=20 > > return isn't a func, so it shouldn't be written like one: > > return memory_read(...); >=20 > Small formatting nit: space before the '(' in function calls... i was letting that one go here because the current code ignores that in mos= t=20 places. but yeah, that would also be nice to fix. -mike --UHN/qo2QbUvPLonB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU+J5vAAoJEEFjO5/oN/WBYdUP/jNiz9y+KLV9Eu5KgNLAFGhZ d+mFR9xq2r7nRQmO5IYVa6oCk6LrQ/QpqQHUAkGqxdFdQUHR9vLD8gCWXP4IETn9 uWKLr6dWMz4qQ0xr4wHrKVg7V7XdPEvNVnwe2uIYX5mYnOnn5JnOjEYQoQrSWOe0 XPPAM/Ebfe8vX787ytffxTdlFuVXa0nGWs4IIakp9y1FbmTDqz8+bQ2DCXidWT/B deT5t9S3VNqmRtty2CRwYAL2/5c6/qhSUyKf/mb2dZgr3f1mgQxi/iUnG249ZVgW lWZhS2pWfquONSaAZUbik+I66vpKvMaemd/2mxG0j3ZKWgq9zXet8nkXBxWZ4PTy 2ULWI19K72t7JmStU9QbC8MF30myCD49UlxZAFFSqgao+hSeQ9lW3Pm3vZTx5SSQ 4d9cowi9Cz7iW3S2Tfd97V8/SSfjSuIVuGmxnCJBl9caUD2z3PYv5fzamEdBSnnR 3XAenvCTPUv/hBh7XBFnh8CRLPXoUQC1xg/sxLVjNyqcjdb3Zz/KjlWc4qn8t8l/ eE5zGSVypc5a4ZWJG93+E8Ae9usXlYA99PW+ndKTfIYaaHmd/32jjZw/EOeZQGA/ rNyJcUqKanVtkxQQNUiKo83kBHiw/lv1uKGx/yF3wu1F0gF5bHXwNLtG4uutxdDn JjfvSPIZy+VHihev7J59 =lH5Q -----END PGP SIGNATURE----- --UHN/qo2QbUvPLonB--