From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26713 invoked by alias); 5 Mar 2015 17:49:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26700 invoked by uid 89); 5 Mar 2015 17:49:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 05 Mar 2015 17:49:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AFB85D3342; Thu, 5 Mar 2015 12:49:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iIvMLmmU2bdE; Thu, 5 Mar 2015 12:49:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 84F8D11646E; Thu, 5 Mar 2015 12:49:33 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BF7CE40EAD; Thu, 5 Mar 2015 09:49:31 -0800 (PST) Date: Thu, 05 Mar 2015 17:49:00 -0000 From: Joel Brobecker To: Jiri Gaisler , gdb-patches@sourceware.org Subject: Re: [PATCH v3 10/14] sim/erc32: Add support for LEON3 processor emulation. Message-ID: <20150305174931.GA4604@adacore.com> References: <1425244244-27709-1-git-send-email-jiri@gaisler.se> <1425244244-27709-11-git-send-email-jiri@gaisler.se> <20150305173521.GB6730@vapier> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150305173521.GB6730@vapier> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-03/txt/msg00160.txt.bz2 > > + return(memory_read(addr, data, sz, ws)); > > return isn't a func, so it shouldn't be written like one: > return memory_read(...); Small formatting nit: space before the '(' in function calls... -- Joel