From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23571 invoked by alias); 2 Mar 2015 01:20:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23535 invoked by uid 89); 2 Mar 2015 01:20:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Mar 2015 01:20:41 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id D4F39340A37; Mon, 2 Mar 2015 01:20:38 +0000 (UTC) Date: Mon, 02 Mar 2015 01:20:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 08/14] sim/erc32: Access memory subsystem through struct memsys. Message-ID: <20150302012039.GL19363@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1425244244-27709-1-git-send-email-jiri@gaisler.se> <1425244244-27709-9-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZrCu0B0FMx3UnjE2" Content-Disposition: inline In-Reply-To: <1425244244-27709-9-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00034.txt.bz2 --ZrCu0B0FMx3UnjE2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 436 On 01 Mar 2015 22:10, Jiri Gaisler wrote: > --- a/sim/erc32/erc32.c > +++ b/sim/erc32/erc32.c >=20=20 > -int dumbio =3D 0; /* normal, smart, terminal oriented IO by default */ > -int tty_setup =3D 1; /* default setup if not a tty */ > +static int tty_setup =3D 1; /* default setup if not a tty */ you just added this in patch 7. shouldn't you squash this change into that= ?=20=20 as well as some of these other uart changes ? -mike --ZrCu0B0FMx3UnjE2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU87rnAAoJEEFjO5/oN/WBIsoQANe3aAuZMUyu44SnlNN8oogS OPqpC5ZD1NsGI5LXkanvD8zWZgY7AgQKOoi/vQShKhpIOd3tyE1e2ydjH9AfCYZ+ tFGFAb47guz/LiYscyMi8kd4PaMEjJb359JPw3/7rNx3YjDjzesf+UxUkvuaVyvP KWW5OR+m6c26q/EgOrkG1WyL0lcFDvxndPzWtwOonCWwNmpHDuo0bSnE/OQkfCL9 R/9Etm/Xzwm8eHPmGqvjOu85UgDoaA6KHioD+ujWkGso64ZfhsxoSXlGysVCAXUf wU/6Z+MDCivMIa013qYQ5K0lOaoASOLb/O+b2rL1Ii/JrGQd+PFqKqWpNwLeu8YR FsnJ0TnrpEFoDn1UZnmtw5wWl0kzMTlzfhBNLc0MiJDkz/5e7cwHcJd16q+9PIbe pcHwBA+hDUDLEHRvM4+PRQbI9P/gqGJ178E/HtNgbJ7UM5yNBQ5u6cSrI/Hclx6p pV5jBBQ/3NSkSSzaDsUoDtsteYThnlYAnEkbv7ipjDTMsrY6uSZmQnnZj8AU7zd8 tRY+oqXy6uhoF4LLpdIggO0BNcHdngU+behWyJVckonguj/S4T/AvlkyQI3fX4nX VOm4xRIiSZbWtDvHqekm8X7OAcMzXHvpiDsk6AbKA/4p+ahPgikWSJilRvNzZP2T f2O4YM7YE/54jolkRNNj =hEgR -----END PGP SIGNATURE----- --ZrCu0B0FMx3UnjE2--