From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21716 invoked by alias); 2 Mar 2015 01:19:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21707 invoked by uid 89); 2 Mar 2015 01:19:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Mar 2015 01:19:13 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id B9266340A1F; Mon, 2 Mar 2015 01:19:10 +0000 (UTC) Date: Mon, 02 Mar 2015 01:19:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 07/14] sim/erc32: Use gdb callback for UART I/O when linked with gdb. Message-ID: <20150302011910.GK19363@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1425244244-27709-1-git-send-email-jiri@gaisler.se> <1425244244-27709-8-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NqNl6FRZtoRUn5bW" Content-Disposition: inline In-Reply-To: <1425244244-27709-8-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00033.txt.bz2 --NqNl6FRZtoRUn5bW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 377 On 01 Mar 2015 22:10, Jiri Gaisler wrote: > --- a/sim/erc32/sis.h > +++ b/sim/erc32/sis.h > > /* Prototypes */ >=20=20 > /* erc32.c */ > -extern void init_sim (void); > +extern void init_sim (); > extern void reset (void); > extern void error_mode (uint32 pc); > extern void sim_halt (void); why ? not only does it look unrelated to this patch, this looks wrong. -mike --NqNl6FRZtoRUn5bW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU87qOAAoJEEFjO5/oN/WB3pYQALIWLCvTFAH8lF5SSXoqNoK9 Upr51Gs8rxIhE+LvCSKUabOBf81n4qXS9GU/GFSKA28oLBlz+z5C7AnHDJj7BzlV CdC/CNAzdOELiCVhJZ4Isa6bCHRaphu9RNNpCOzxinWKlLev+Enrmtli5PQLHDzW yvuBN/IPBctwIyQOW0GevwswiVkUK1krlhA1Fqscy/krzxDwswnjlA2r6jvHizvd MpjE6H/sZJPkRa4aLGCf1hvt4yN3937rMrTq5jqkm2l9kzH4hUBSazWOVYA64YVq rHGKqsQZgXh2to6SosaYDzO2y5WwdOtZGfyHySpQvGSIfqPYvdkfyoaCx6ueFRSG bB/MQCPLRYcbhWJgAUgSE12DBuhk4XfEHn3/S8blPTJ9IMyqHDU6QJI6L62o+yol srFPZjaAx5N0UNeFN3PoMhVUqmY9OyCHK4tOQ9iL+NHc7nVHdvbIJbjq+o9JAZtn 7j4xdvdohylUMASiphXCeTDupFsHcNwQ6AnoYBsKiItoDUy1dKaTFZHJvLCXfSip KHycMWCjyGeSRvE8qH2CsQ4csogZhfrRqo9jeA8wnx0iT+aH9BjkDts9oYnjsYyA ehhbBj6sOdlj6nGtpiTf7pJIuXRpJgjRASIhsT2CCe2XDqs0jwC1NYXz5kMIZbd0 z70EP7EMnWfT0hDfqCBs =/Ypy -----END PGP SIGNATURE----- --NqNl6FRZtoRUn5bW--