From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18523 invoked by alias); 2 Mar 2015 01:15:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18508 invoked by uid 89); 2 Mar 2015 01:15:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Mar 2015 01:15:47 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id BA676340A1F; Mon, 2 Mar 2015 01:15:44 +0000 (UTC) Date: Mon, 02 Mar 2015 01:15:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 05/14] sim/erc32: Use memory_iread() function for instruction fetching. Message-ID: <20150302011544.GI19363@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1425244244-27709-1-git-send-email-jiri@gaisler.se> <1425244244-27709-6-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D6z0c4W1rkZNF4Vu" Content-Disposition: inline In-Reply-To: <1425244244-27709-6-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00031.txt.bz2 --D6z0c4W1rkZNF4Vu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 437 On 01 Mar 2015 22:10, Jiri Gaisler wrote: > --- a/sim/erc32/erc32.c > +++ b/sim/erc32/erc32.c > > + return (0); drop the paren > + return (0); here too > + printf("Memory exception at %x (illegal address)\n", addr); space after the printf should this be writing to stderr ? > --- a/sim/erc32/interf.c > +++ b/sim/erc32/interf.c > > + mexc = memory_iread(sregs->pc, &sregs->inst, &sregs->hold); space before the ( -mike --D6z0c4W1rkZNF4Vu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU87nAAAoJEEFjO5/oN/WBxyEP/0bwpbV5dkbzll8NpFhlBPtg xu5eTGekzmK4m+/MFicxc1F5jqeBi4YvYvF+IDhjl74GqkvttI1SYVjglvJDleV7 Rpf8XA9WaWQ4wjembSGhU3SrdiR1pw5vN/eJIHdjB4FzJIBqNEwbPMfWl7WI1UBl j+GtZFpzJJprNE4waPj1Yx4rcX0XpiAdV8Cl0Zvqve/IMuXAqYzbfJ068j0aJSCX VDrorAIYTclKdqzQveM7tWosWLKO+ZgPL65H+PJ62GO27QybJYyIH7A/5p5QYiMw 82Hl6cO+TIpa7aAJxpEA6Vy69IYhd0EHhDi1et8w8z5s8b/4g6D5CTs5a4nxfY5p m3O3JhPRM6alPNo5FHx+5B1kIoCuLzadRNvM3aI0Z7lut8oAjDsmh/HASSlsdmcL pOyYko8CsFYGzVmkxsluHEvJBMuUgz18NJyZ5a3++JQooQPo6CKdIWmYwg+Oqio6 Z0L0BV5JfWV1YI/yxEz9Peshjp6DLHPNKKjHTk35H+0tLrO/wR8+Zuex6arU3lPI easRyA04lzJTDdS/clfqQhD8pMNVXAgsmgOKHKePO7IW4UfT2p2vrkCsHOpNR5w5 sv1X9K3w3VW0wzPHza/JERB3nocLEZS9KtlwNJzWmtlpp2X5V3JdJLqqLCy2iyl1 z/KYT/zhIqrXK/aU2Hbp =f+fz -----END PGP SIGNATURE----- --D6z0c4W1rkZNF4Vu--