From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109307 invoked by alias); 26 Feb 2015 09:23:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109293 invoked by uid 89); 26 Feb 2015 09:23:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Feb 2015 09:23:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 18ADC11657A; Thu, 26 Feb 2015 04:23:35 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sDoQ9NZiTR19; Thu, 26 Feb 2015 04:23:35 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EA6DB116573; Thu, 26 Feb 2015 04:23:34 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B300B40EAD; Thu, 26 Feb 2015 10:23:33 +0100 (CET) Date: Thu, 26 Feb 2015 09:23:00 -0000 From: Joel Brobecker To: Jon TURNEY Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Retrieve segment registers on Windows amd64 Message-ID: <20150226092333.GB31815@adacore.com> References: <1424435625-3708-1-git-send-email-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424435625-3708-1-git-send-email-jon.turney@dronecode.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00741.txt.bz2 Jon, > For amd64, CONTEXT_FULL does not contain CONTEXT_SEGMENTS, which seems to be > needed to retrieve all the segment registers. Add it explicitly, with > a little de-cruftification. > > The value of the segment registers isn't terribly useful on amd64, but > at least this makes the output of 'info registers' correct. > > before: > > (gdb) i r cs ss ds es fs gs > cs 0x33 51 > ss 0x2b 43 > ds 0x0 0 > es 0x0 0 > fs 0x0 0 > gs 0x0 0 > > after: > > (gdb) i r cs ss ds es fs gs > cs 0x33 51 > ss 0x2b 43 > ds 0x2b 43 > es 0x2b 43 > fs 0x53 83 > gs 0x2b 43 > > gdb/ChangeLog > > 2015-02-19 Jon TURNEY > > * windows-nat.c (CONTEXT_DEBUGGER_DR): Add CONTEXT_SEGMENTS. Thanks for the patch. The patch looks good to me. The ChangeLog needs to identify all the changes were made, and in particular, it needs to mention the fact that CONTEXT_DEBUGGER's declaration was removed. Do you have a GDB copyright assignment on file. The patch is small enough that we can take it as a "tiny patch", but if you have other patches in the pipeline, then you'll eventually need to fill one out. Let me know if you'd like to get started on the process, it takes a few weeks to complete, as I understand it. -- Joel