From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48117 invoked by alias); 26 Feb 2015 08:18:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48107 invoked by uid 89); 26 Feb 2015 08:18:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Feb 2015 08:18:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5D2BC1165AC; Thu, 26 Feb 2015 03:18:01 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vFZg+r9iPW2D; Thu, 26 Feb 2015 03:18:01 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 287721165A4; Thu, 26 Feb 2015 03:18:01 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0EA5940EAD; Thu, 26 Feb 2015 09:18:00 +0100 (CET) Date: Thu, 26 Feb 2015 08:18:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Phil Muldoon , gdb-patches@sourceware.org Subject: Re: [patchv2] compile: Fix GNU-IFUNC funcs called from injected code Message-ID: <20150226081800.GA31815@adacore.com> References: <20150224190720.GA32497@host1.jankratochvil.net> <20150224200237.GA1746@host1.jankratochvil.net> <54ED85CC.7030506@redhat.com> <20150225172944.GA28033@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150225172944.GA28033@host1.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00737.txt.bz2 > On Wed, 25 Feb 2015 09:20:28 +0100, Phil Muldoon wrote: > > Not sure if we allow // comments yet. > > Given the codebase already contains them and additionally it should get > converted to C++ I assume they are OK. Let's please hold them off until the project is officially a C++ project. At the moment, we support the building of GDB using a pure C compiler which may not understand those. If other areas use them already, I consider that a bug. -- Joel