From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-120208-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 97091 invoked by alias); 25 Feb 2015 17:29:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 97075 invoked by uid 89); 25 Feb 2015 17:29:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 25 Feb 2015 17:29:50 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1PHTmJM003386	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)	for <gdb-patches@sourceware.org>; Wed, 25 Feb 2015 12:29:48 -0500
Received: from host1.jankratochvil.net ([10.40.204.17])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1PHTidq025409	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);	Wed, 25 Feb 2015 12:29:47 -0500
Date: Wed, 25 Feb 2015 17:29:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patchv2] compile: Fix GNU-IFUNC funcs called from injected code
Message-ID: <20150225172944.GA28033@host1.jankratochvil.net>
References: <20150224190720.GA32497@host1.jankratochvil.net> <20150224200237.GA1746@host1.jankratochvil.net> <54ED85CC.7030506@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54ED85CC.7030506@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes
X-SW-Source: 2015-02/txt/msg00721.txt.bz2

On Wed, 25 Feb 2015 09:20:28 +0100, Phil Muldoon wrote:
> Not sure if we allow // comments yet.

Given the codebase already contains them and additionally it should get
converted to C++ I assume they are OK.


> > +      if (TYPE_GNU_IFUNC (SYMBOL_TYPE (sym)))
> > +        result = gnu_ifunc_resolve_addr (target_gdbarch (), result);
> 
> Is this guaranteed to return a value to result (or an exception)?

Yes.


Jan