From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26497 invoked by alias); 22 Feb 2015 21:06:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26487 invoked by uid 89); 22 Feb 2015 21:06:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 22 Feb 2015 21:06:24 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id B132D340BAA; Sun, 22 Feb 2015 21:06:21 +0000 (UTC) Date: Sun, 22 Feb 2015 21:06:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 19/22] sim/erc32: Add support for LEON2 processor emulation. Message-ID: <20150222210621.GI31422@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1424385100-15397-1-git-send-email-jiri@gaisler.se> <1424385100-15397-20-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sl5MdczEF/OU2Miu" Content-Disposition: inline In-Reply-To: <1424385100-15397-20-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00640.txt.bz2 --sl5MdczEF/OU2Miu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 753 On 19 Feb 2015 23:31, Jiri Gaisler wrote: > + * Leon2 emulation, based on leon3.c . no space before the . > +/* The control space devices */ GNU style is to put periods at the end and then two spaces: /* The control space devices. */ you'll need to fix in the whole file > +static int tty_setup =3D 1; /* default setup if not a tty */ prefer to avoid inline comments especially when they aren't needed like here > +#define APBEND 0x80000100 the defines mix a lot of spaces and tabs. you shouldn't have a space befor= e a=20 tab. > +static void > +init_sim() all these should be (void) > +static void > +error_mode(pc) > + uint32 pc; > +{ please fix old style function prototypes > +struct memsys leon2 =3D { const ? -mike --sl5MdczEF/OU2Miu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU6kTNAAoJEEFjO5/oN/WBW8QP/3xF1/9g63SkS284JMgwjyUu e48ChKb8eGE/tcGDyj1JZ50ed49YAW2TNEZLXJOsEe4+d/Ln2B+22L/Q8LDMw7LU HQ8m2vmvwTVhipWU2WRZru8R7lDfTC1ignZt3JPtU8yvGIBZ8HsjUEPyg1l6NXtl nDmi/8jQVex2v2RKNedFMZFfQIIDqvZ61q4BSRaRKkBuuGmwljUn88S15zLd2Bnk JhJLUULR6kPa3dpFYp53dt+lgDabjnTFOG9RZG6GRQfrJoOBQj1BGTQl5JAfNFWL 13HiupoRclgENXkiXu3iMyZpHkwrUIXh6Wq8teVX4MVgxQPcqkzTR1K770QqNsRD xay4amBPBguMqulPcU0qKjXUkojGOeuIDGKTg0wgVItYL6lsKc43qZoH01WJA5lO uLtLPOTdByXtk0iYDrLnv+l6Ru8AdRngDREk1TkJ4D1XFfFdPUrw+pQ3vN2W5lqe +tWa49/Bx3VVir6R0KCwLsPQMmgo2MEGeT9ju+lD/l80SACyG29hwHlviTcZzpaj spy1RpdRzdv/idz5OCCobWOfO2SnO8TnlKEQ5o573yG+uRNnDe145boiRsVdK17g NrueqzndnPnElEOCdqo+NVi32zZd4+j4+2h4aBR6igC3rhhKe3ebCfQmjpY570/j UYL4cHsehuBEzQGP+CAB =7UVu -----END PGP SIGNATURE----- --sl5MdczEF/OU2Miu--