From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22728 invoked by alias); 22 Feb 2015 04:43:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22718 invoked by uid 89); 22 Feb 2015 04:43:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 22 Feb 2015 04:43:49 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id E4936340AA8; Sun, 22 Feb 2015 04:43:46 +0000 (UTC) Date: Sun, 22 Feb 2015 04:43:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 09/22] sim/erc32: Removed type mismatch compiler warnings Message-ID: <20150222044347.GE25220@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1424385100-15397-1-git-send-email-jiri@gaisler.se> <1424385100-15397-10-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FEz7ebHBGB6b2e8X" Content-Disposition: inline In-Reply-To: <1424385100-15397-10-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00627.txt.bz2 --FEz7ebHBGB6b2e8X Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 687 On 19 Feb 2015 23:31, Jiri Gaisler wrote: > + tmp =3D getline(&lbuf, &len, fp); > + if ((strlen(lbuf) > 0) && (lbuf[strlen(lbuf) - 1] =3D=3D '\n')) { you need to check the return value of tmp before using lbuf > + if (lbuf) free(lbuf); no need for the if check ... free(NULL) required to work in POSIX > + uint32 len, i, clen, j, tmp; > ... > + tmp =3D system(&cmdsave[clen]); the return value of system() is int, not uint32 ... then again, you aren't checking the return value. i guess you just want to= =20 silence the warning ? that doesn't work in gcc. you'll want to do: if (system(&cmdsave[clen])) { /* Silence unused return value warning. */ } -mike --FEz7ebHBGB6b2e8X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU6V6DAAoJEEFjO5/oN/WBNHcP/0LgYKHiyvqSwI2WLnoWI3c5 gDhR/xxI6G13SdcZMRgj6/kDlvVXWhFAeZJiQhqqGk9FVzHsQ5Sa0v3TaVSDzOmZ apb6TL0/84SoTxs7CrJOnnKty2EacjoU3CGogf2hr5UyfS3AMA1tqU42ZV+SRs/u 9uVnUCgDY+f5mTUPHthMdFPeeCNOs3cnluDWKl00mGcqUX9eLBMzpJ8oWX5BHFqy 2Z/TWERBEN4v8V6+XuaWTCnQcaOccsCJwAkZwKoXfHfpAsqRA2PG5B4dAmgAezsw UALcWeAdk7Bqzaz0q8FyiamaDidVB761dH43NWtCOjiyABash1qtz6C96a98DRGl jvuvFH7ZQQhcYB4oFEEzDuAHT810hwXM1lrhcj6df/ec7hWnEk+HkkKOjs6S2VaR 4CPUd0NOR5k5Z9oMfhQKBG8IaGHeP/SIzx926Y8Mx2gPnPecCUmNDCs4QifUU7Ue iE6r4lpVQibhLtP8XvJu7m2h/pdJEZf7swWnk38AP9Ih8+mpUnFCWL3ey87GQsrV zY5k48tZHO0snGloN0NQmDfIzBMwILxa0TUmFOKn9TLBAyr953zXVEz0USrlktX4 kiLcP/GgaWNjhe/5JWZovCQeGGWCa/gdvv0gvHez73gw8QSczn+npV4ltk7OhA6f 6AcEgyVFEzAIXWoXz4X9 =JU62 -----END PGP SIGNATURE----- --FEz7ebHBGB6b2e8X--