From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27140 invoked by alias); 18 Feb 2015 23:10:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26267 invoked by uid 89); 18 Feb 2015 23:10:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Feb 2015 23:10:35 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 116A2340727; Wed, 18 Feb 2015 23:10:31 +0000 (UTC) Date: Wed, 18 Feb 2015 23:10:00 -0000 From: Mike Frysinger To: "H.J. Lu" Cc: Mark Wielaard , Joel Brobecker , GCC Patches , Binutils , GDB Subject: Re: ping #3: [RFA] Add --with-libz-prefix option in config/zlib.m4 Message-ID: <20150218231032.GZ544@vapier> Mail-Followup-To: "H.J. Lu" , Mark Wielaard , Joel Brobecker , GCC Patches , Binutils , GDB References: <20150218165457.GU544@vapier> <20150218194443.GW544@vapier> <1424291541.23458.28.camel@bordewijk.wildebeest.org> <1424295643.23458.30.camel@bordewijk.wildebeest.org> <20150218222140.GY544@vapier> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XUd+PsnCfaVdInSg" Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00504.txt.bz2 --XUd+PsnCfaVdInSg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1892 On 18 Feb 2015 14:24, H.J. Lu wrote: > On Wed, Feb 18, 2015 at 2:21 PM, Mike Frysinger wrote: > > i think we already have the reports: multiple people don't think it sho= uld be > > (1) x86-specific or (2) required. don't get me wrong -- i think having= support > > like this is great. that doesn't mean we should be forcing it. >=20 > Please file a bug report with a testcase. this is getting kafka-esque. you yourself stated: On Linux/x86, zlib is required for assembler. At least, you should issue= an=20 error when --without-libz is used in binutils for Linux/x86 target. that should not be the case. making someone open a bug report so you can c= lose=20 it with "fixed" and a patch is wasting time. just fix it now. all that said, if we look at your actual commit (89e7505fcde4bd83948f559f42= 9a0): gas/config/tc-i386.c: +#ifdef TE_LINUX +/* Default to compress debug sections for Linux. */ +int flag_compress_debug =3D 1; +#endif and we look at where that flag is used: gas/as.c: ... case OPTION_COMPRESS_DEBUG: #ifdef HAVE_ZLIB_H flag_compress_debug =3D 1; #else as_warn (_("cannot compress debug sections (zlib not installed)")); #endif /* HAVE_ZLIB_H */ break; case OPTION_NOCOMPRESS_DEBUG: flag_compress_debug =3D 0; break; ... gas/write.c: void write_object_file (void) { ... if (flag_compress_debug) bfd_map_over_sections (stdoutput, compress_debug, (char *) 0); ... static void compress_debug (bfd *abfd, asection *sec, void *xxx ATTRIBUTE_UNUSED) { ... strm =3D compress_init (); if (strm =3D=3D NULL) return; it turns out the current code does *not* require zlib. as long as that doe= s not=20 change (either issuing a warning or throwing an error), i see no reason why= we=20 need or should make zlib a requirement in binutils, regardless of target. -mike --XUd+PsnCfaVdInSg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU5RvoAAoJEEFjO5/oN/WBZlIP/1LyjZz4cBO+uUXeVqslxp1k fM/rYEFMyKCojq7TlzMiWLemrHyH1AGizByhzMhsjdKRzloKQmnNphYvvTkmrAWD TbAWfcdK7WmhhCosoC0aZVW/qKegiXfL1hLbSXtSusMAh01m1vwWRxzb6Jq/lK+1 wAgBUS+YprmxQZaZaLweEyqsAOtc/j2jUdS5EAGEy2PiWw9sdwLTUMLAjUcFDgOm cFkek2lGCoU1ojvnirNGgaFV8LZXPUAa8hLKZ3VzD4wt6LUaGcQaosNE1jt0CjFy Gd4pO/UAJGUI+Fdw2cGEE4tFCECLtugfrvebOoEWJgEjTOM3YzFs5bHLqIk8DJz7 M5GnTP3AeC4a2AUUC6Zppwf8oP90YQhrawjE0q4CFDtFu1LcQpN6Q4qCB3ZqH3wY m5qtStN+OnJnPkQkoLG9CZ/dwbfJW2yG99rEd6yxkH7tpswYBLuGfTbE8LB2AD96 eQKQX81LDEGunDGFCg+U/pbFzDLvm3AxU31sZTF1x2DqYX6YzCOQBy8P1051sLkX BvKfoTKZYOr4EBIVRsTLWF/J2LtRIP8CZr1rZ6m9QU1czIxLk8MDmW83vO0OYZPR 30+d9ZmroDoCaIGVLNTBbHOguOYIZ9gwlIlmE2EDhgIVLE2QRNcruJ4MI59jW0V2 0Oydjsq+jIkTk132BTFd =J/wL -----END PGP SIGNATURE----- --XUd+PsnCfaVdInSg--