From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6473 invoked by alias); 18 Feb 2015 19:55:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6410 invoked by uid 89); 18 Feb 2015 19:55:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Feb 2015 19:55:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1IJsvL1004149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Feb 2015 14:54:58 -0500 Received: from tucnak.zalov.cz (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1IJssjS007760 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 18 Feb 2015 14:54:56 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t1IJsqh3010439; Wed, 18 Feb 2015 20:54:53 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t1IJsp6L010438; Wed, 18 Feb 2015 20:54:51 +0100 Date: Wed, 18 Feb 2015 19:55:00 -0000 From: Jakub Jelinek To: Pedro Alves Cc: Andrew Pinski , "gdb-patches@sourceware.org" , GCC Patches Subject: Re: [PATCH 09/36] floatformat.h: Wrap in extern "C". Message-ID: <20150218195451.GS1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1423524046-20605-1-git-send-email-palves@redhat.com> <1423524046-20605-10-git-send-email-palves@redhat.com> <54D94780.9050606@redhat.com> <54DC932D.6000904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54DC932D.6000904@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-02/txt/msg00495.txt.bz2 On Thu, Feb 12, 2015 at 11:49:01AM +0000, Pedro Alves wrote: > On 02/09/2015 11:49 PM, Pedro Alves wrote: > > On 02/09/2015 11:35 PM, Andrew Pinski wrote: > >> On Mon, Feb 9, 2015 at 3:20 PM, Pedro Alves wrote: > >>> Just like libiberty.h. So that C++ programs, such as GDB when built > >>> as a C++ program, can use it. > >> > >> Why is not needed for GCC building with C++ compiler? > > > > Because it doesn't include it. > > > > The header of the file claims it is part of GDB, though MAINTAINERS > > nowadays says that everything under include/ is owned by GCC. > > Here's an update that moves the extern "C" below the #include. > > OK to push to the GCC repo? > > From: Pedro Alves > Subject: [PATCH] floatformat.h: Wrap in extern "C". > > Just like libiberty.h. So that C++ programs, such as GDB when built > as a C++ program, can use it. > > include/ChangeLog: > 2015-02-12 Pedro Alves > > * floatformat.h [__cplusplus]: Wrap in extern "C". Ok, thanks. Jakub