Re: [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings

Jiri Gaisler
2015-02-18T14:41:01Z

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

On 02/17/2015 10:10 AM, Mike Frysinger wrote:
> On 17 Feb 2015 08:44, Jiri Gaisler wrote:
>> --- a/sim/erc32/func.c
>> +++ b/sim/erc32/func.c
>>
>> - fgets(lbuf, 1023, fp);
>> + tmp = fgets(lbuf, 1023, fp);
>
> not a new issue, but fgets needs to die in a fire. getline is a trivial API and
> does a lot of nice stuff for you :).
> -mike
>

I thought fgets was secure, as it cannot write past the (statically) allocated buffer.

Jiri.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]