From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26050 invoked by alias); 17 Feb 2015 09:13:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26033 invoked by uid 89); 17 Feb 2015 09:13:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Feb 2015 09:13:38 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 32FE9340863; Tue, 17 Feb 2015 09:13:35 +0000 (UTC) Date: Tue, 17 Feb 2015 09:13:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 08/23] sim/erc32: added -v and -vv command line switches for verbose output Message-ID: <20150217091334.GN20008@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1424159099-5148-1-git-send-email-jiri@gaisler.se> <1424159099-5148-9-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TXIPBuAs4GDcsx9K" Content-Disposition: inline In-Reply-To: <1424159099-5148-9-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00415.txt.bz2 --TXIPBuAs4GDcsx9K Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 791 On 17 Feb 2015 08:44, Jiri Gaisler wrote: > --- a/sim/erc32/sis.c > +++ b/sim/erc32/sis.c > > - printf(" %8u ", ebase.simtime); > + printf(" %8llu ", ebase.simtime); if i'm reading things correctly, simtime is a uint64, which means you shoul= d=20 include inttypes.h and use PRIu64 here instead of hardcoding llu. same goes for the other changes you're making like this below. > @@ -214,6 +214,10 @@ main(argc, argv) > #endif > } else if (strcmp(argv[stat], "-dumbio") =3D=3D 0) { > dumbio =3D 1; > + } else if (strcmp(argv[stat], "-v") =3D=3D 0) { > + sis_verbose =3D 1; > + } else if (strcmp(argv[stat], "-vv") =3D=3D 0) { > + sis_verbose =3D 2; what about -v -v ? maybe the -v handler should increment sim_verbose inste= ad -mike --TXIPBuAs4GDcsx9K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU4wY+AAoJEEFjO5/oN/WByk0QAMO6gs2yu6qEp4/DFpVLJjth ciZmGZvecc5jww9rjzbcHFc71qKUi9zpVWW5LlenqveVXQKz4sx2vJgkwNN9LXyN 5LM6ik8oAwmVA8qB7KjehvsZDeiZBR00Gdq9Onp6qNTbprshpyrxSen1G4jXYZWR N1sc6Bw1WU6iU0o3Dhj1mHzQEv90QxXdrTdA8wII7JsTiNSRmGXtPqAZ2ePzZMC8 qC5aAvLZbwV4Ejcju6HVI4G3sgM6l+bpVrVV/NGvfpimAxiUsOXcmImiJ3Eoqhbg SSJXsnDdDpP3lNOeHmMqeVgpriISGydPDJ95b0HVGJvB4qZEGZVOmCvZwhK26sc+ ZTuZbxw7a0kJzfN/QVeUzQF4DqgsovXaVPh8t+1kMSdaCSAfZJ6Z02IiBFa8voSv BzUgM1gE2PpjTTo9gZBGlGjzFNeVs20vyMTVNPtrVv/1dgNNBZQnZGt8rXnGO6PL K95R8gsflzquuuvMDkGLZXdxAdTYwyuOaDNftjwiiO2xOEw0IOuT1vmN7/ju59+y jhDYgyB7YTP07QP4iVpSt6wTjxDCTmnaJF8P2len83q/FnT5pRRlShguvPN7od9X rKQybt5WJDZpfK0a6kBiPqhwYoBTbj/tWbfy4uW01W6HcZ0IXJ3Ve7BoTLavz+H1 sGxY9ZptSCoezUUGU3IA =YUdO -----END PGP SIGNATURE----- --TXIPBuAs4GDcsx9K--