From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15802 invoked by alias); 17 Feb 2015 09:10:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15788 invoked by uid 89); 17 Feb 2015 09:10:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Feb 2015 09:10:39 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 146AF340865; Tue, 17 Feb 2015 09:10:36 +0000 (UTC) Date: Tue, 17 Feb 2015 09:10:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings Message-ID: <20150217091036.GM20008@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1424159099-5148-1-git-send-email-jiri@gaisler.se> <1424159099-5148-10-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bZ2MuwyI/0uB8yuJ" Content-Disposition: inline In-Reply-To: <1424159099-5148-10-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00414.txt.bz2 --bZ2MuwyI/0uB8yuJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 286 On 17 Feb 2015 08:44, Jiri Gaisler wrote: > --- a/sim/erc32/func.c > +++ b/sim/erc32/func.c > > - fgets(lbuf, 1023, fp); > + tmp =3D fgets(lbuf, 1023, fp); not a new issue, but fgets needs to die in a fire. getline is a trivial AP= I and=20 does a lot of nice stuff for you :). -mike --bZ2MuwyI/0uB8yuJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU4wWMAAoJEEFjO5/oN/WBNGYQAKzmRTGqKItXxnHufKOdMCm/ w0n1qiXov4iQGSXayD22zkzCFKMrAEjE/d9NXJ8gzTdrW3Kzp+0A1uQbIg8x3N5u +cbeeoOXV1oTHNmmxF8L3TxJJKPeJioTFNA67S8FkHw1ujZTGFSAhIPNX5rtx4l0 CWFRROPApniz5HkpHuLoFDP9MU9zHVHEqQOUSNKC8B/VF3bLnZ7Q37Oxi5zja5dc s9clnadx3jFf8GNjhv50CiUop56CJNRThBdc0WV450WDxdf347w+YFZsiZRUimUP +rG9POqhwJlQiZwqVVoww2TCebl905B92o8LruiMsFSXCXXIor9XYe4YlccdaILc bBx7NyuIz7y0EDImn2P2cnfrizKEWlcZXyUx7PpctyWTLqgz+oK81q6yByvzyrI6 y/pNnIH9XDSxB479DXR+BS3rNrusMfrNUiCQ4ApczgYkqpgvYDve6tYwiHa7C3zp tnRgOFbGXisAz9O10PSFySN24utss+80+5os/7Twj0ko97xikSbxcYgRzjNpUhEo po17NqEd3uujddVa+aLFJjT/Q15T02nR6FkpeKChgpjFRJLOC2iLG08gC4AYn+3Q 8m+elV18vURRz1A4jc1IRt8pHXn0lIMngYcdfyvexOHZJ7HxCMzAOhcjLUwddjqR ZTBloR7Z1Q/Pqdef5K9f =YpfI -----END PGP SIGNATURE----- --bZ2MuwyI/0uB8yuJ--