On Thu, 05 Feb 2015 10:47:49 +0100, Pedro Alves wrote:
> It's not obvious to me why is the file uuencoded.  What's the
> reason for that?

I do not find it convenient to check in a binary, while GIT can handle that
diff+patch do not.

If you prefer a different encoding method I do not mind.


> > +# Wrongly built GDB complains by:
> > +# "..." is not a core dump: File format not recognized
> > +# As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it.
> > +# This is just a problem of the test care, real-world elf64-i386 file will have
> > +# 32bit PRSTATUS.  One cannot prepare elf64-i386 core file from elf32-i386 by
> > +# objcopy as it corrupts the core file beyond all recognition.
> > +# "\r\nCore was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal 11, Segmentation fault\\.\r\n.*"
> 
> Hmm, this line is commented out, but there's no explanation of why
> that is.  Is that a left over that was intended to be used in the
> gdb_test below?  As is, it seems like the gdb_test below will PASS
> even on buggy GDB?

The goal of this testcase is the final test:
	x/i 0x400078
	   0x400078:    hlt    
	(gdb) PASS: gdb.arch/i386-biarch-core.exp: .text is readable

If the core-file command fails to load the core file data it will get caught
by this final test anyway.

I really have no idea after 6 years why the expect string is commented out
there.  Therefore I have put in into the gdb_test command now together with
the new warning:
	(gdb) core-file /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.core^M
	[New LWP 6901]^M
	warning: Unexpected size of section `.reg/6901' in core file.^M
	Failed to read a valid object file image from memory.^M
	Core was generated by `./bad'.^M
	Program terminated with signal SIGSEGV, Segmentation fault.^M
	warning: Unexpected size of section `.reg/6901' in core file.^M
	#0  0x00000200 in ?? ()^M
	(gdb) PASS: gdb.arch/i386-biarch-core.exp: core-file
->
	gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file"



Thanks,
Jan