From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4647 invoked by alias); 11 Feb 2015 07:57:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4633 invoked by uid 89); 11 Feb 2015 07:57:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 11 Feb 2015 07:57:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 447EE11675C; Wed, 11 Feb 2015 02:57:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id WLEpi8gIRVDR; Wed, 11 Feb 2015 02:57:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DC89E116757; Wed, 11 Feb 2015 02:57:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 215E540EAD; Wed, 11 Feb 2015 11:57:49 +0400 (RET) Date: Wed, 11 Feb 2015 07:57:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/36] C++ keyword cleanliness, mostly auto-generated Message-ID: <20150211075749.GJ4738@adacore.com> References: <1423524046-20605-1-git-send-email-palves@redhat.com> <1423524046-20605-4-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423524046-20605-4-git-send-email-palves@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00292.txt.bz2 On Mon, Feb 09, 2015 at 11:20:13PM +0000, Pedro Alves wrote: > This patch renames symbols that happen to have names which are > reserved keywords in C++. > > Most of this was generated with Tromey's cxx-conversion.el script. > Some places where later hand massaged a bit, to fix formatting, etc. > And this was rebased several times meanwhile, along with re-running > the script, so re-running the script from scratch probably does not > result in the exact same output. I don't think that matters anyway. > > gdb/ > 2015-02-09 Tom Tromey > Pedro Alves > > Rename symbols whose names are reserved C++ keywords throughout. *if* this is reasonably easy to do, can we rename "namespace" into "domain" instead of "the_namespace"? "namespace" comes from our old terminology, I think, and we've been using "enum_domain" since, so if we're going to have to change the variable/parameter names also, might as well use "domain" instead? -- Joel