From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12595 invoked by alias); 10 Feb 2015 23:51:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12582 invoked by uid 89); 10 Feb 2015 23:51:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Feb 2015 23:51:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1ANp12Y024020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Feb 2015 18:51:01 -0500 Received: from blokker.wildebeest.org (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1ANoxDO007833 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 10 Feb 2015 18:51:01 -0500 Received: by blokker.wildebeest.org (Postfix, from userid 1000) id 0AFAB2068A; Wed, 11 Feb 2015 00:50:59 +0100 (CET) Date: Tue, 10 Feb 2015 23:51:00 -0000 From: Mark Wielaard To: Patrick Palka Cc: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers. Message-ID: <20150210235058.GD17507@blokker.redhat.com> References: <1422185341-20243-1-git-send-email-mjw@redhat.com> <20150129080018.GH5193@adacore.com> <1422535409.4947.5.camel@bordewijk.wildebeest.org> <1423070384.4947.47.camel@bordewijk.wildebeest.org> <20150204180550.GC4738@adacore.com> <1423079956.4947.52.camel@bordewijk.wildebeest.org> <1423600163.4947.86.camel@bordewijk.wildebeest.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-02/txt/msg00281.txt.bz2 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 330 On Tue, Feb 10, 2015 at 06:15:44PM -0500, Patrick Palka wrote: > Now that producer_is_gcc() returns a bool, shouldn't the statement > 'return -1' become 'return false;', and the statement 'return major;' > become 'return true;'? Yes, of course. What a silly mistake. Thanks for catching that. I pushed the attached as obvious. --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-gdb-producer_is_gcc-fix-bool-return-value.patch" Content-length: 1189 >From 9f615e3af0356052a475812cb5a4380a5fe51182 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 11 Feb 2015 00:45:31 +0100 Subject: [PATCH] gdb producer_is_gcc fix bool return value. gdb/ChangeLog: * utils.c (producer_is_gcc): Return true or false. --- gdb/ChangeLog | 4 ++++ gdb/utils.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a23c2d8..fe61d24 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-02-11 Mark Wielaard + + * utils.c (producer_is_gcc): Return true or false. + 2015-02-04 Mark Wielaard * utils.h (producer_is_gcc): Change return type to bool. Add major diff --git a/gdb/utils.c b/gdb/utils.c index 2b54739..3ce5814 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -3299,11 +3299,11 @@ producer_is_gcc (const char *producer, int *major, int *minor) if (*cs && isspace (*cs)) cs++; if (sscanf (cs, "%d.%d", major, minor) == 2) - return major; + return true; } /* Not recognized as GCC. */ - return -1; + return false; } /* Helper for make_cleanup_free_char_ptr_vec. */ -- 2.1.0 --Dxnq1zWXvFF0Q93v--