From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9129 invoked by alias); 8 Feb 2015 16:00:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9114 invoked by uid 89); 8 Feb 2015 16:00:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 08 Feb 2015 16:00:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 213CB116530; Sun, 8 Feb 2015 11:00:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MawRMeGIOipw; Sun, 8 Feb 2015 11:00:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 31B5A1163D8; Sun, 8 Feb 2015 11:00:15 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EC99240EAF; Sun, 8 Feb 2015 20:00:10 +0400 (RET) Date: Sun, 08 Feb 2015 16:00:00 -0000 From: Joel Brobecker To: Chen Gang S Cc: Doug Evans , "gdb-patches@sourceware.org" Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings. Message-ID: <20150208160010.GE4738@adacore.com> References: <54D61EFC.3040000@sunrus.com.cn> <54D6A794.7080107@sunrus.com.cn> <54D6BE70.2080708@sunrus.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54D6BE70.2080708@sunrus.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00182.txt.bz2 > >>>> 2015-02-07 Chen Gang > >>>> > >>>> * mcore/interp.c: Include "unistd.h" standard C header file to > >>>> avoid compiling warnings. A couple of small procedural nits... There is a ChangeLog file in sim/mcore, so this is the one that should be updated, and thus the name of the file in the ChangeLog entry should not have the "mcore/" part. Also, the ChangeLog entry should only say "what" has been changed, not "why". If you feel that the "why" needs to be provided, it should be provided in the code. In this case, I feel that your revision log is sufficient. So, your ChangeLog entry should look like: 2015-02-07 Chen Gang * interp.c: Include "unistd.h". -- Joel