Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Phil Muldoon <pmuldoon@redhat.com>
Subject: [PATCH 1/6] framefilter quit: Obvious whitespacing fixes
Date: Sat, 07 Feb 2015 14:45:00 -0000	[thread overview]
Message-ID: <20150207144508.14897.90189.stgit@host1.jankratochvil.net> (raw)
In-Reply-To: <20150207144501.14897.90709.stgit@host1.jankratochvil.net>

Hi,

planned to be checked in with the series.


Jan


gdb/ChangeLog
2015-02-06  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* python/py-framefilter.c (py_print_frame): Whitespacing fixes.
---
 gdb/python/py-framefilter.c |   28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/gdb/python/py-framefilter.c b/gdb/python/py-framefilter.c
index 97dce89..c1c2653 100644
--- a/gdb/python/py-framefilter.c
+++ b/gdb/python/py-framefilter.c
@@ -1052,7 +1052,6 @@ py_print_frame (PyObject *filter, int flags,
       goto error;
     }
 
-
   /* stack-list-variables.  */
   if (print_locals && print_args && ! print_frame_info)
     {
@@ -1077,15 +1076,15 @@ py_print_frame (PyObject *filter, int flags,
 	 and are printed with indention.  */
       if (indent > 0)
 	{
-	TRY_CATCH (except, RETURN_MASK_ALL)
-	  {
-	    ui_out_spaces (out, indent*4);
-	  }
-	if (except.reason < 0)
-	  {
-	    gdbpy_convert_exception (except);
-	    goto error;
-	  }
+	  TRY_CATCH (except, RETURN_MASK_ALL)
+	    {
+	      ui_out_spaces (out, indent*4);
+	    }
+	  if (except.reason < 0)
+	    {
+	      gdbpy_convert_exception (except);
+	      goto error;
+	    }
 	}
 
       /* The address is required for frame annotations, and also for
@@ -1175,7 +1174,7 @@ py_print_frame (PyObject *filter, int flags,
 
 	      if (gdbpy_is_string (py_func))
 		{
-		  char *function_to_free = NULL;
+		  char *function_to_free;
 
 		  function = function_to_free =
 		    python_string_to_host_string (py_func);
@@ -1208,7 +1207,6 @@ py_print_frame (PyObject *filter, int flags,
 		  goto error;
 		}
 
-
 	      TRY_CATCH (except, RETURN_MASK_ALL)
 		{
 		  annotate_frame_function_name ();
@@ -1254,8 +1252,8 @@ py_print_frame (PyObject *filter, int flags,
 
       if (PyObject_HasAttrString (filter, "filename"))
 	{
-	  PyObject *py_fn = PyObject_CallMethod (filter, "filename",
-						 NULL);
+	  PyObject *py_fn = PyObject_CallMethod (filter, "filename", NULL);
+
 	  if (py_fn != NULL)
 	    {
 	      if (py_fn != Py_None)
@@ -1344,7 +1342,7 @@ py_print_frame (PyObject *filter, int flags,
     }
 
   /* Finally recursively print elided frames, if any.  */
-  elided  = get_py_iter_from_func (filter, "elided");
+  elided = get_py_iter_from_func (filter, "elided");
   if (elided == NULL)
     goto error;
 


  parent reply	other threads:[~2015-02-07 14:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07 14:45 [PATCH 0/6] framefilter quit: PR cli/17716 Jan Kratochvil
2015-02-07 14:45 ` [PATCH 3/6] framefilter quit: Code cleanup: Avoid gotos Jan Kratochvil
2015-02-11 13:43   ` [commit+7.9] " Jan Kratochvil
2015-02-07 14:45 ` [PATCH 4/6] framefilter quit: Make it exception safe Jan Kratochvil
2015-02-11 13:45   ` [commit+7.9] " Jan Kratochvil
2015-02-07 14:45 ` Jan Kratochvil [this message]
2015-02-11 13:37   ` [commit+7.9] [PATCH 1/6] framefilter quit: Obvious whitespacing fixes Jan Kratochvil
2015-02-07 14:45 ` [PATCH 5/6] framefilter quit: Use RETURN_MASK_ERROR Jan Kratochvil
2015-02-11 13:52   ` [commit+7.9] " Jan Kratochvil
2015-02-07 14:45 ` [PATCH 6/6] framefilter quit: New test Jan Kratochvil
2015-02-11 13:56   ` [commit+7.9] " Jan Kratochvil
2015-02-07 14:45 ` [PATCH 2/6] framefilter quit: Code cleanup: Reindentation Jan Kratochvil
2015-02-11 13:39   ` [commit+7.9] " Jan Kratochvil
2015-02-10 17:40 ` [PATCH 0/6] framefilter quit: PR cli/17716 Pedro Alves
2015-02-10 19:19   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150207144508.14897.90189.stgit@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox