Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().

Chen Gang S
2015-02-17T23:10:26Z

On 2/17/15 18:34, Mike Frysinger wrote:
> On 31 Jan 2015 07:07, Chen Gang S wrote:
>> --- a/sim/ChangeLog
>> +++ b/sim/ChangeLog
>> @@ -1,5 +1,10 @@
>> 2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> + * microblaze/interp.c (sim_do_command): Call freeargv() before
>> + return.
>
> this should be in sim/microblaze/ChangeLog instead. it looks like your last 4
> entries in sim/ChangeLog need to get relocated. please do so.
>

Oh, really, I shall change the related comments.

> while you're there, you should also fix your gentmap.c entry in
> sim/common/ChangeLog -- only one space after the * is used.
>

Oh, really, I shall change the related comments.

> as for the actual code, lgtm. thanks for fixing up the various error paths.
> -mike

That what I should do, since I focus on binutils and gdb. :-)

And excuse me, I am not quite familiar with the related working flow.
Can I send 1 patch to fix the 2 comments, and "git push" it after it is
reviewed?.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed