Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().

Chen Gang S
2015-01-29T05:01:27Z

On 1/29/15 12:49, Joel Brobecker wrote:
> [binutils does not need to be copied in this case, as you're only
> touching files in the simulator, which is part of the GDB project]
>
>> 2015-01-28 Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> * common/sim-options.c (sim_args_command): Call freeargv() when
>> failure occurs.
>> * mcore/interp.c (sim_do_command): Call freeargv() before return.
>> * microblaze/interp.c (sim_do_command): Call freeargv() before
>> return.
>
> Small procedural request, Chen. Those 3 changes are pretty much
> independent, so it's highly preferable to submit them separately.
> This has a number of advantages: We can review each one of them
> individually, with possibly different reviewers, and that makes
> tracking of which part has been reviewed a lot easier. Also, by
> having them submitted separately, you can have one patch per piece,
> which means that if one patch turns out to be incorrect, we can
> easily revert just that patch using git, rather than doing a semi-
> revert by hand.
>

OK, thanks. I shall send 3 separated patches for it within this month.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed