[PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().

Chen Gang S
2015-01-30T22:59:28Z

Or there will be memory leak.

2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>

* microblaze/interp.c (sim_do_command): Call freeargv() before
return.
---
sim/ChangeLog | 5 +++++
sim/microblaze/interp.c | 3 +++
2 files changed, 8 insertions(+)

diff --git a/sim/ChangeLog b/sim/ChangeLog
index 1fe93df..582bd4a 100644
--- a/sim/ChangeLog
+++ b/sim/ChangeLog
@@ -1,5 +1,10 @@
2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>

+ * microblaze/interp.c (sim_do_command): Call freeargv() before
+ return.
+
+2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>
+
* mcore/interp.c (sim_do_command): Call freeargv() before return.

2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>
diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
index 1c8a22d..4fc4595 100644
--- a/sim/microblaze/interp.c
+++ b/sim/microblaze/interp.c
@@ -1019,6 +1019,7 @@ sim_do_command (SIM_DESC sd, const char *cmd)
if ((simargv[1] == NULL) || (simargv[2] == NULL))
{
fprintf (stderr, "Error: missing argument to watch cmd.\n");
+ freeargv (simargv);
return;
}

@@ -1062,6 +1063,8 @@ sim_do_command (SIM_DESC sd, const char *cmd)
fprintf (stderr,"Error: \"%s\" is not a valid M.CORE simulator command.\n",
cmd);
}
+
+ freeargv (simargv);
}
else
{
--
1.9.3