From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17244 invoked by alias); 30 Jan 2015 03:35:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17224 invoked by uid 89); 30 Jan 2015 03:35:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 03:35:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1573A1167A7; Thu, 29 Jan 2015 22:35:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id py36iqLBxGBc; Thu, 29 Jan 2015 22:35:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A3F9B116610; Thu, 29 Jan 2015 22:35:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 24191491CD; Fri, 30 Jan 2015 07:35:45 +0400 (RET) Date: Fri, 30 Jan 2015 16:41:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] Mention that create_child takes ownership of the allocated name Message-ID: <20150130033545.GM5193@adacore.com> References: <1422559716-5480-1-git-send-email-simon.marchi@ericsson.com> <1422559716-5480-5-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422559716-5480-5-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00793.txt.bz2 > gdb/ChangeLog: > > * varobj.c (create_child): Modify comment. OK, with one favor if you wouldn't mind. > --- > gdb/varobj.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/varobj.c b/gdb/varobj.c > index 0daef91..d3fa1ba 100644 > --- a/gdb/varobj.c > +++ b/gdb/varobj.c > @@ -2043,7 +2043,9 @@ uninstall_variable (struct varobj *var) > > } > > -/* Create and install a child of the parent of the given name. */ > +/* Create and install a child of the parent of the given name. > + > + The created VAROBJ takes ownership of the allocated NAME. */ > static struct varobj * GDB's Coding Style requires that we have an empty line between function documentation and function definition. It was missing here, and since you're touching this area, would you mind adding it? Thank you! -- Joel