From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15873 invoked by alias); 30 Jan 2015 03:33:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15858 invoked by uid 89); 30 Jan 2015 03:33:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 03:33:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8E1F3116347; Thu, 29 Jan 2015 22:33:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IEdKYheZUZbv; Thu, 29 Jan 2015 22:33:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 241EA11633E; Thu, 29 Jan 2015 22:33:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9811A491CD; Fri, 30 Jan 2015 07:33:26 +0400 (RET) Date: Fri, 30 Jan 2015 09:03:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Constify some parameters in the varobj code Message-ID: <20150130033326.GL5193@adacore.com> References: <1422559716-5480-1-git-send-email-simon.marchi@ericsson.com> <1422559716-5480-4-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422559716-5480-4-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00792.txt.bz2 > I did that to make sure there was no other cases like the one fixed in > the previous patch. I don't think it can hurt. Agreed. > gdb/ChangeLog: > > * ada-varobj.c (ada_number_of_children): Constify struct varobj * > parameter. > (ada_name_of_variable): Same. > (ada_path_expr_of_child): Same. > (ada_value_of_variable): Same. > (ada_value_is_changeable_p): Same. > (ada_value_has_mutated): Same. > * c-varobj.c (varobj_is_anonymous_child): Same. > (c_is_path_expr_parent): Same. > (c_number_of_children): Same. > (c_name_of_variable): Same. > (c_path_expr_of_child): Same. > (get_type): Same. > (c_value_of_variable): Same. > (cplus_number_of_children): Same. > (cplus_name_of_variable): Same. > (cplus_path_expr_of_child): Same. > (cplus_value_of_variable): Same. > * jv-varobj.c (java_number_of_children): Same. > (java_name_of_variable): Same. > (java_path_expr_of_child): Same. > (java_value_of_variable): Same. > * varobj.c (number_of_children): Same. > (name_of_variable): Same. > (is_root_p): Same. > (varobj_ensure_python_env): Same. > (varobj_get_objname): Same. > (varobj_get_expression): Same. > (varobj_get_display_format): Same. > (varobj_get_display_hint): Same. > (varobj_has_more): Same. > (varobj_get_thread_id): Same. > (varobj_get_frozen): Same. > (dynamic_varobj_has_child_method): Same. > (varobj_get_gdb_type): Same. > (is_path_expr_parent): Same. > (varobj_default_is_path_expr_parent): Same. > (varobj_get_language): Same. > (varobj_get_attributes): Same. > (varobj_is_dynamic_p): Same. > (varobj_get_child_range): Same. > (varobj_value_has_mutated): Same. > (varobj_get_value_type): Same. > (number_of_children): Same. > (name_of_variable): Same. > (check_scope): Same. > (varobj_editable_p): Same. > (varobj_value_is_changeable_p): Same. > (varobj_floating_p): Same. > (varobj_default_value_is_changeable_p): Same. > * varobj.h (struct lang_varobj_ops): Consitfy some struct varobj * > parameters. > (varobj_get_objname): Constify struct varobj * parameter. > (varobj_get_expression): Same. > (varobj_get_thread_id): Same. > (varobj_get_frozen): Same. > (varobj_get_child_range): Same. > (varobj_get_display_hint): Same. > (varobj_get_gdb_type): Same. > (varobj_get_language): Same. > (varobj_get_attributes): Same. > (varobj_editable_p): Same. > (varobj_floating_p): Same. > (varobj_has_more): Same. > (varobj_is_dynamic_p): Same. > (varobj_ensure_python_env): Same. > (varobj_default_value_is_changeable_p): Same. > (varobj_value_is_changeable_p): Same. > (varobj_get_value_type): Same. > (varobj_is_anonymous_child): Same. > (varobj_value_get_print_value): Same. > (varobj_default_is_path_expr_parent): Same. Sorry you had to write such as long ChangeLog entry. CL can be useful at times, but really a timewaster at others :-(. The patch looks pretty good to me, with a few corrections to avoid some lines that became too long. Pre-approved with those adjustments. -- Joel