From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8139 invoked by alias); 19 Jan 2015 18:05:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8126 invoked by uid 89); 19 Jan 2015 18:05:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e31.co.us.ibm.com Received: from e31.co.us.ibm.com (HELO e31.co.us.ibm.com) (32.97.110.149) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 19 Jan 2015 18:05:05 +0000 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Jan 2015 11:05:03 -0700 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Jan 2015 11:05:00 -0700 Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id AB82919D801C for ; Mon, 19 Jan 2015 10:56:11 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0JI50iW41287916 for ; Mon, 19 Jan 2015 11:05:00 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0JI4xTl025087 for ; Mon, 19 Jan 2015 11:04:59 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t0JI4uSm024611; Mon, 19 Jan 2015 11:04:56 -0700 Message-Id: <201501191804.t0JI4uSm024611@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 19 Jan 2015 19:04:47 +0100 Subject: Re: [PATCH 2/3 v4] Process record support for PowerPC To: cole945@gmail.com (Wei-cheng Wang) Date: Mon, 19 Jan 2015 18:05:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org In-Reply-To: <54BD2C4B.7010102@gmail.com> from "Wei-cheng Wang" at Jan 20, 2015 12:09:47 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15011918-8236-0000-0000-000008BF3981 X-SW-Source: 2015-01/txt/msg00530.txt.bz2 Wei-cheng Wang wrote: > 2015-01-18 Wei-cheng Wang > > * rs6000-tdep.c (ppc_process_record_op4, ppc_process_record_op19, > ppc_process_record_op31, ppc_process_record_op59, > ppc_process_record_op60, ppc_process_record_op63, > ppc_process_record): Fix -Wformat warning. > * rs6000-tdep.c (rs6000_epilogue_frame_cache, ppc_process_record_op60): > Remove unused variables. This is OK. Please check this in to fix the reported build issues. > 2015-01-18 Wei-cheng Wang > > * ppc-linux-tdep.c (ppc_skip_trampoline_code, > ppc_canonicalize_syscall, ppc_linux_syscall_record, > ppc_linux_record_signal, ppc_init_linux_record_tdep): Add comments. > * ppc64-tdep.c (ppc64_skip_trampoline_code): Likewise. > * rs6000-tdep.c (rs6000_epilogue_frame_cache, > rs6000_epilogue_frame_this_id, rs6000_epilogue_frame_prev_register, > rs6000_epilogue_frame_sniffer, ppc_record_vsr, ppc_process_record_op4, > ppc_process_record_op19, ppc_process_record_op31, > ppc_process_record_op59, ppc_process_record_op60, > ppc_process_record_op63): Likewise. A couple of minor issues: > +/* Record registers which might be clobbered during system call. > + Return 0 if succeed. */ I think proper English usage would be "Return 0 on success." or "Return 0 if sucessful." (Here and elsewhere in the patch.) > -/* Initialize linux_record_tdep if not initialized yet. */ > +/* Initialize linux_record_tdep if not initialized yet. > + WORDSIZE is 4 or 8 for 32- or 64-bit PowerPC Linux respectively. > + Sizes of data structures are initilzied accordingly. */ Typo "initilzied". Otherwise, this is OK as well. Two other things as an aside: - When committing a patch to git, please add the ChangeLog to the git commit message as well. Have a look with "git log" at the existing practice how to format the commit messages for GDB. - Given that you've now got commit access, please also add your name to the MAINTAINERS file under "Write After Approval"; see here for a recent example: https://sourceware.org/ml/gdb-patches/2015-01/msg00517.html Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com