From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26553 invoked by alias); 19 Jan 2015 07:48:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26521 invoked by uid 89); 19 Jan 2015 07:48:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 19 Jan 2015 07:48:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6F6811163D8; Mon, 19 Jan 2015 02:48:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id n-t0K+djiUTe; Mon, 19 Jan 2015 02:48:32 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 29E07116294; Mon, 19 Jan 2015 02:48:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 19CC248E89; Mon, 19 Jan 2015 08:48:30 +0100 (CET) Date: Mon, 19 Jan 2015 07:48:00 -0000 From: Joel Brobecker To: Wei-cheng Wang Cc: Jan Kratochvil , Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: Broken build: rs6000-tdep.c: 32-bit host --enable-targets=all --enable-64-bit-bfd [Re: [PATCH 2/3 v4] Process record support for PowerPC] Message-ID: <20150119074830.GA4041@adacore.com> References: <201501171146.t0HBktpk008932@d03av02.boulder.ibm.com> <20150117185342.GA10419@adacore.com> <20150117212014.GA32152@host2.jankratochvil.net> <54BB3AC2.6050507@gmail.com> <20150118065908.GA12626@host2.jankratochvil.net> <54BB676B.2090101@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54BB676B.2090101@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00511.txt.bz2 Wei-Cheng, > Using %s+paddress instead of %lx+long in this patch. > > Thanks, > Wei-cheng The change looks fine to me, but there is no ChangeLog. Also, I ended glancing at some of the patches you recently pushed, and noticed that you added a lot of new functions for which there is no introductory comment describing the function's behavior and arguments. It is now mandatory that all new functions, no matter how trivial, have such introductory comment. Would you mind going back over your patches, and send a patch that adds the missing comments, please? > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index 75811d1..6e37622 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -3356,7 +3356,6 @@ rs6000_epilogue_frame_cache (struct frame_info *this_frame, void **this_cache) > struct rs6000_frame_cache *cache; > struct gdbarch *gdbarch = get_frame_arch (this_frame); > struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > - CORE_ADDR sp; > > if (*this_cache) > return *this_cache; > @@ -3957,8 +3956,8 @@ ppc_process_record_op4 (struct gdbarch *gdbarch, struct regcache *regcache, > return 0; > } > > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, 4-%d.\n", insn, addr, ext); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, 4-%d.\n", insn, paddress (gdbarch, addr), ext); > return -1; > } > > @@ -4000,8 +3999,8 @@ ppc_process_record_op19 (struct gdbarch *gdbarch, struct regcache *regcache, > return 0; > } > > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, 19-%d.\n", insn, addr, ext); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, 19-%d.\n", insn, paddress (gdbarch, addr), ext); > return -1; > } > > @@ -4458,7 +4457,8 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache, > case 878: /* Transaction Abort Doubleword Conditional Immediate */ > case 910: /* Transaction Abort */ > fprintf_unfiltered (gdb_stdlog, "Cannot record Transaction instructions. " > - "%08x at %08lx, 31-%d.\n", insn, addr, ext); > + "%08x at %s, 31-%d.\n", > + insn, paddress (gdbarch, addr), ext); > return -1; > > case 1014: /* Data Cache Block set to Zero */ > @@ -4477,8 +4477,8 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache, > } > > UNKNOWN_OP: > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, 31-%d.\n", insn, addr, ext); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, 31-%d.\n", insn, paddress (gdbarch, addr), ext); > return -1; > } > > @@ -4569,8 +4569,8 @@ ppc_process_record_op59 (struct gdbarch *gdbarch, struct regcache *regcache, > return 0; > } > > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, 59-%d.\n", insn, addr, ext); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, 59-%d.\n", insn, paddress (gdbarch, addr), ext); > return -1; > } > > @@ -4582,7 +4582,6 @@ ppc_process_record_op60 (struct gdbarch *gdbarch, struct regcache *regcache, > { > struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > int ext = PPC_EXTOP (insn); > - int tmp; > > switch (ext >> 2) > { > @@ -4852,8 +4851,8 @@ ppc_process_record_op60 (struct gdbarch *gdbarch, struct regcache *regcache, > return 0; > } > > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, 60-%d.\n", insn, addr, ext); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, 60-%d.\n", insn, paddress (gdbarch, addr), ext); > return -1; > } > > @@ -5018,8 +5017,8 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, > > } > > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, 59-%d.\n", insn, addr, ext); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, 59-%d.\n", insn, paddress (gdbarch, addr), ext); > return -1; > } > > @@ -5298,8 +5297,8 @@ ppc_process_record (struct gdbarch *gdbarch, struct regcache *regcache, > > default: > UNKNOWN_OP: > - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " > - "%08x at %08lx, %d.\n", insn, addr, op6); > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at %s, %d.\n", insn, paddress (gdbarch, addr), op6); > return -1; > } > > -- -- Joel