Broken build: rs6000-tdep.c: 32-bit host --enable-targets=all --enable-64-bit-bfd [Re: [PATCH 2/3 v4] Process record support for PowerPC]

Jan Kratochvil
2015-01-17T21:20:28Z

On Sat, 17 Jan 2015 19:53:42 +0100, Joel Brobecker wrote:
> > Excellent! Please go ahead and commit those patches to mainline.
[...]
> Sure, OK, especially since you are saying impact should be minimal.

commit b4cdae6fe51e532e0b1069c6960b14a610182d14
Author: Wei-cheng Wang <cole945@gmail.com>
Date: Sat Jan 17 14:30:33 2015 +0800
Reverse debugging for PowerPC.

Fedora 22 i386 (32-bit host):
./configure --enable-targets=all --enable-64-bit-bfd --disable-binutils;make
gcc -g -O2 -I. -I. -I./common -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -pthread -I/usr/include/guile/2.0 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o rs6000-tdep.o -MT rs6000-tdep.o -MMD -MP -MF .deps/rs6000-tdep.Tpo rs6000-tdep.c
rs6000-tdep.c: In function ‘ppc_process_record_op4’:
rs6000-tdep.c:3961:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CORE_ADDR’ [-Werror=format=]
"%08x at %08lx, 4-%d.\n", insn, addr, ext);
^
[...]
cc1: all warnings being treated as errors
Makefile:1112: recipe for target 'rs6000-tdep.o' failed

The patches are not (yet?) on gdb-7.9-branch so 7.9 is not affected.
It also probably would not break the build as 7.9 will have --disable-werror.

Jan