From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Commit hook annoyance
Date: Fri, 16 Jan 2015 16:26:00 -0000 [thread overview]
Message-ID: <20150116162556.GT8167@adacore.com> (raw)
In-Reply-To: <20150116161841.GS8167@adacore.com>
> > There was no unresolved conflicts in the commit I tried to push. Why
> > does the hook insist on forcing me to remove the "Conflicts:" part,
> > instead of looking for the merge-commit conflict markers? Why do we
> > care about leaving the reference to original conflicts in the log?
Sorry - re-reading your question, I am now realizing that I was not
really answering what you asked. So, let me try it again.
I think we do care, IMO, because the information is really useless.
And also, as I said, users often don't even realize that git does
that for them. I'd rather have a little hassle right now, in favor
of sanitized revision logs forever.
I don't think it's a big hassle to have to remove them, myself.
But if the consensus to remove the check, we can enhance the hooks
to make it optional.
--
Joel
next prev parent reply other threads:[~2015-01-16 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 15:59 Eli Zaretskii
2015-01-16 16:10 ` H.J. Lu
2015-01-16 16:38 ` Eli Zaretskii
2015-01-16 16:18 ` Joel Brobecker
2015-01-16 16:26 ` Joel Brobecker [this message]
2015-01-16 16:42 ` Eli Zaretskii
2015-01-16 17:45 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116162556.GT8167@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox