From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31988 invoked by alias); 15 Jan 2015 15:39:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31977 invoked by uid 89); 15 Jan 2015 15:39:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 15 Jan 2015 15:39:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0FFdW1n026171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Jan 2015 10:39:33 -0500 Received: from blade.nx (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0FFdV4A032042; Thu, 15 Jan 2015 10:39:32 -0500 Received: by blade.nx (Postfix, from userid 1000) id 25987264D73; Thu, 15 Jan 2015 15:39:31 +0000 (GMT) Date: Thu, 15 Jan 2015 15:39:00 -0000 From: Gary Benson To: Doug Evans Cc: Eli Zaretskii , gdb-patches Subject: Re: [PATCH 3/3 v2] Implement completion limiting Message-ID: <20150115153930.GA14900@blade.nx> References: <1417094168-25868-1-git-send-email-gbenson@redhat.com> <1417094168-25868-4-git-send-email-gbenson@redhat.com> <20141210122233.GA7299@blade.nx> <21671.20308.262958.475080@ruffy2.mtv.corp.google.com> <20150107084255.GA17867@blade.nx> <21680.36641.315766.209208@ruffy2.mtv.corp.google.com> <83a91r6lbd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00428.txt.bz2 Doug Evans wrote: > On Sat, Jan 10, 2015 at 1:23 AM, Eli Zaretskii wrote: > > > From: Doug Evans > > > Date: Fri, 9 Jan 2015 18:32:01 -0800 > > > Cc: gdb-patches@sourceware.org > > > > > > +If the number of possible completions is large, @value{GDBN} will > > > +print as much of the list as it has collected, as well as a message > > > +indicating that the list may be truncated. > > > + > > > +@smallexample > > > +(@value{GDBP}) b m@key{TAB}@key{TAB} > > > +m *** List may be truncated, max-completions reached. *** > > > +main > > > +<... the rest of the possible completions ...> > > > +(@value{GDBP}) b m > > > > Doesn't the "list may be truncated" message scrolls off the > > screen, if the list is long enough? If so, wouldn't it be better > > to display that message at the end instead, saying something like > > > > (More completions follow; max-completions exceeded.) > > If the user sets a bad height, or if pagination is turned off, > possibly. > > I can put it at the end. I'd prefer it at the end. Cheers, Gary -- http://gbenson.net/