From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28315 invoked by alias); 14 Jan 2015 11:29:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28302 invoked by uid 89); 14 Jan 2015 11:29:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 14 Jan 2015 11:29:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 716BC11654C; Wed, 14 Jan 2015 06:29:47 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qOOWUygdCObp; Wed, 14 Jan 2015 06:29:47 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0042B116523; Wed, 14 Jan 2015 06:29:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 08FA848E8B; Wed, 14 Jan 2015 15:29:43 +0400 (RET) Date: Wed, 14 Jan 2015 11:29:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] PR17525 - breakpoint commands not executed when program run, from -x script Message-ID: <20150114112942.GK8167@adacore.com> References: <54B56B60.6040406@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B56B60.6040406@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00369.txt.bz2 Hi Pedro, > gdb/ > 2015-01-12 Pedro Alves > > PR gdb/17525 > * breakpoint.c: Include "interps.h". > (bpstat_do_actions_1): Also check whether the interpreter is > async. > > gdb/testsuite/ > 2015-01-12 Pedro Alves > Joel Brobecker > > PR gdb/17525 > * gdb.base/bp-cmds-execution-x-script.c: New file. > * gdb.base/bp-cmds-execution-x-script.exp: New file. > * gdb.base/bp-cmds-execution-x-script.gdb: New file. Many many thanks for the fix. I completely missed the fact that we were running in non-async mode, and now I am slapping the front of my head yelling a "duh!". I learnt something from your help, so thank you. And the bonus is that the fix looks fairly simple, which is good, because... ... this is an issue which was identified as a regression for 7.8 and 7.9. I suggest we backport them to both branches, if you agree, and once the patch is pushed to master, I volunteer doing so if that saves you a bit of time. Regarding GDBFLAGS, I'm wondering whether this might be one of those globals that we should be restoring at the start of each testcase (via gdb_init)... -- Joel