From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28048 invoked by alias); 13 Jan 2015 09:31:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28034 invoked by uid 89); 13 Jan 2015 09:31:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 13 Jan 2015 09:31:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E0C4D1163FE for ; Tue, 13 Jan 2015 04:31:01 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XRAHvafhM5Fh for ; Tue, 13 Jan 2015 04:31:01 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 678C71163E0 for ; Tue, 13 Jan 2015 04:31:01 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DC4E448E89; Tue, 13 Jan 2015 13:30:56 +0400 (RET) Date: Tue, 13 Jan 2015 09:31:00 -0000 From: Joel Brobecker To: David Taylor Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] PR 17520 -- structure offset wrong when 1/4 GB or greater Message-ID: <20150113093056.GD8167@adacore.com> References: <1418954030-16797-1-git-send-email-dtaylor@emc.com> <20141220182725.GI12884@adacore.com> <19519.1421081631@usendtaylorx2l> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19519.1421081631@usendtaylorx2l> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00326.txt.bz2 > > Can you add a copyright header to that file, please? All files should > > have a copyright header unless there is a compelling reason whe cannot > > add it. > > Done. > > The file is short enough that I'm not sure that it really is > copyrightable -- but, the lawyers can argue that one, I don't care. Indeed, some files might be small enough as to not be legally significant in terms of copyright issues. But rather than introduce a human decision into the mix, it's just easier to add copyright headers everywhere. And we have the script which updates all copyright notices everywhere at the start of the year which tells us if new files have been introduced without a copyright header. > I noticed that most of the testsuite *.c files, at least in gdb.base > do not have copyright notices. That is a mistake that we should be correcting, but it usually takes someone seeing the error, then digging through history to figure out the copyright range, and then adding it. > I found an example that did something similar to what I wanted and > copied it. It had the timeout within the gdb_test_multiple, so that is > what I did, too. For TCL, I do the same, but unfortunately, there is a lot of old baggage, as you've discovered. We try to fix this too, as we see it, but it's a nearly endless source of work, so progress is usually, er, slow (understatement). In case you haven't seen it yet, there is a cookbook: http://sourceware.org/gdb/wiki/GDBTestcaseCookbook If some recipes are missing, we'd be glad to add to it. > I try to do as little as possible in Tcl as every time I do anything > significant, by the time I'm done I'm remembering just how much I hate > writing Tcl code. +1. -- Joel