From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix jit-reader.h for multilib
Date: Wed, 07 Jan 2015 17:36:00 -0000 [thread overview]
Message-ID: <20150107173634.GA13295@host2.jankratochvil.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
Hi,
I got reported jit-reader.h is not multi-lib safe:
--- /usr/include/gdb/jit-reader.h on x86_64 2015-01-07 11:54:27.705802129 -0500
+++ /usr/include/gdb/jit-reader.h on i686 2015-01-07 11:54:46.853774165 -0500
@@ -56,7 +56,7 @@ extern "C" {
/* Represents an address on the target system. */
-typedef unsigned long GDB_CORE_ADDR;
+typedef unsigned long long GDB_CORE_ADDR;
/* Return status codes. */
multi-lib safety means that files with the same pathname (which is
/usr/include, contrary to /usr/lib vs. /usr/lib64 for example).
The patch will make it on x86_64 also 'unsigned long long'.
OK for check-in?
Thanks,
Jan
[-- Attachment #2: multilib.patch --]
[-- Type: text/plain, Size: 969 bytes --]
gdb/ChangeLog
2015-01-07 Jan Kratochvil <jan.kratochvil@redhat.com>
* configure: Regenerate.
* configure.ac (TARGET_PTR): Try "unsigned long long" first.
diff --git a/gdb/configure.ac b/gdb/configure.ac
index ec776d7..c02ace9 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -648,10 +648,12 @@ AC_CHECK_SIZEOF(unsigned long long)
AC_CHECK_SIZEOF(unsigned long)
AC_CHECK_SIZEOF(unsigned __int128)
-if test "x${ac_cv_sizeof_unsigned_long}" = "x8"; then
- TARGET_PTR="unsigned long"
-elif test "x${ac_cv_sizeof_unsigned_long_long}" = "x8"; then
+# Try to keep TARGET_PTR the same across archs so that jit-reader.h file
+# content is the same for multilib distributions.
+if test "x${ac_cv_sizeof_unsigned_long_long}" = "x8"; then
TARGET_PTR="unsigned long long"
+elif test "x${ac_cv_sizeof_unsigned_long}" = "x8"; then
+ TARGET_PTR="unsigned long"
elif test "x${ac_cv_sizeof_unsigned___int128}" = "x16"; then
TARGET_PTR="unsigned __int128"
else
next reply other threads:[~2015-01-07 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 17:36 Jan Kratochvil [this message]
2015-01-11 12:02 ` Yao Qi
2015-01-11 13:14 ` Jan Kratochvil
2015-01-12 2:33 ` Yao Qi
2015-01-12 8:42 ` Jan Kratochvil
2015-01-12 9:57 ` Joel Brobecker
2015-06-03 19:42 ` ping: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107173634.GA13295@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox