From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17719 invoked by alias); 20 Dec 2014 17:18:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17705 invoked by uid 89); 20 Dec 2014 17:18:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 20 Dec 2014 17:18:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6D81B11640B; Sat, 20 Dec 2014 12:18:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AGG8PsAL0Z-w; Sat, 20 Dec 2014 12:18:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5E1F0116409; Sat, 20 Dec 2014 12:18:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D93BB40164; Sat, 20 Dec 2014 12:18:29 -0500 (EST) Date: Sat, 20 Dec 2014 17:18:00 -0000 From: Joel Brobecker To: Alastair Robertson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Printing of large objects not interruptable Message-ID: <20141220171829.GF12884@adacore.com> References: <20141208223958.4de115f7@arch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141208223958.4de115f7@arch> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00589.txt.bz2 > This patch makes the counting of repeated characters interruptable, > relating to bug 17613 > https://sourceware.org/bugzilla/show_bug.cgi?id=17613 > > This is my first patch, so sorry if I forgot to include something or > didn't format it correctly. > > 2014-12-07 Alastair Robertson > > PR gdb/17613 > * valprint.c (count_next_character): Call QUIT This patch looks good to me. If you could add a short description of what this PR is about in the commit's revision log, so as to avoid the need to go through a PR, which is not always a straightforward (or even concise read), that would be very good. In terms of items for submission, we have a checklist: https://sourceware.org/gdb/wiki/ContributionChecklist There is a lot of important information there, if you haven't read it yet. As far as this patch is concerned, the only bits that are missing are a period at the end of your sentence in your ChangeLog entry; and an indication that you ran the testsuite before and after your patch, showing no regression (this one is unlikely to produce any, but better safe than sorry) - that indication should be in the commit's revision log, including the platform that was used to perform the testing. Please re-send an updated patch, and I will push it for you. Thank you! > diff --git a/gdb/valprint.c b/gdb/valprint.c > index b995304..8d743b1 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -2151,6 +2151,8 @@ count_next_character (struct wchar_iterator *iter, > > while (1) > { > + QUIT; > + > /* Get the next character. */ > d.num_chars > = wchar_iterate (iter, &d.result, &chars, &d.buf, &d.buflen); -- Joel