From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6511 invoked by alias); 13 Dec 2014 23:33:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6500 invoked by uid 89); 13 Dec 2014 23:33:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 13 Dec 2014 23:33:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1E906116464; Sat, 13 Dec 2014 18:33:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7okY1qvnkUYu; Sat, 13 Dec 2014 18:33:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0E8A11163FB; Sat, 13 Dec 2014 18:33:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 19DD740164; Sat, 13 Dec 2014 18:33:53 -0500 (EST) Date: Sat, 13 Dec 2014 23:33:00 -0000 From: Joel Brobecker To: Doug Evans Cc: "gdb-patches@sourceware.org" Subject: Re: [COMMITTED PATCH] Fix off-by-one error in make_hex_string. Message-ID: <20141213233353.GO5457@adacore.com> References: <20141213222317.GN5457@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00340.txt.bz2 > I can imagine it's because the toolchain you used didn't add a build id. > Just a guess though. Yes, that's probably it. We need a unit test framework... ;-) -- Joel