[PATCH V5 0/3] Intel(R) AVX-512 register support

Michael Sturm
2014-04-23T13:03:35Z

Pedro,

thanks for your review. We've addressed the comments you made regarding the
test case and the manual content. We do agree to your comment
regarding sharing code between GDB and GDBserver. We would prefer to
make this change in a patch dedicated to unify XSAVE buffer access
between GDB and GDBserver.

Would you agree to that and approve committing this series?

Thanks and regards,
Michael and Fred.

This patch series adds support for the Intel(R) Advanced Vector Extensions 512
(Intel(R) AVX-512) registers. Native and remote debugging are covered by this
patch series.

Intel(R) AVX-512 is an extension to AVX to support 512-bit wide SIMD registers
in 64-bit mode (XMM0-XMM31, YMM0-YMM31, ZMM0-ZMM31). The number of available
registers in 32-bit mode is still 8 (XMM0-7, YMM0-7, ZMM0-7). The lower
256-bits of the ZMM registers are aliased to the respective 256-bit YMM
registers. The lower 128-bits are aliased to the respective 128-bit XMM
registers.

There are also 8 new, dedicated mask registers (K0-K7) in both 32-bit mode
and 64-bit mode.

For more information please see
Intel(R) Developer Zone: Intel(R) AVX
http://software.intel.com/en-us/intel-isa-extensions#pid-16007-1495

Intel(R) Architecture Instruction Set Extensions Programming Reference:
http://software.intel.com/en-us/file/319433-017pdf

Changes between V4 and V5:
* Addressed comment by Pedro:
i386-avx512.c: Fixed formatting to follow GNU coding style. Removed
depdendency to stdio.h.
i386-avx512.exp: Changed test for AVX512 CPU support to probe test
following Pedro's proposal. Fixed indentation.
gdb.textinfo: Changed wording to makeit clearer which of the new
registers are present in 64-bit mode only.

Changes between V3 and V4:
* Addressed comments by Pedro:
All: Fixed year in copyright notice .
i386-linux-tdep.h: Added parens to I386_LINUX_ORIG_EAX_REGNUM define.
i386-tdep.c: Removed spurious new line.
Several places: Compare return value of memcmp to 0.
i386-avx512.exp: Chanegs to ensure test case returns "unsupported" on
machines that don't have AVX-512. Redesigned test case.
i386-avx512.c: Changes following redesign of test case.

Changes between V2 and V3:
* Following feeback by Mark Kettenis, the follwing changes were made
in i386-tdep.c:
Changed a reference to "amd64" to "in 64-bit mode" in the comment
explaining the need for a constant. Also, refactored is_AVX512,
is_AVX, is_SSE in i386_register_reggroup_p to avx512_p, avx_p, sse_p.

Changes between V1 and V2:
* Following feedback by Pedro Alves, i386-avx512.exp now using
gdb_test_multiple when checking if AVX512 is supported by the
CPU. If CPU does not support AVX512, return unsupported.
Simplified test as timeout is handled by framework. Added newline
at the end of file.

Note:
* Documentation patch V1 already approved by Eli.
* AVX512 register patch for GDB V3 pre-approved by Mark.
* Add AVX512 register support to gdbserver V3 approved by Pedro.

Michael Sturm (3):
Add AVX512 registers support to GDB.
Add AVX512 register support to gdbserver.
Add AVX512 feature description to GDB manual

gdb/NEWS | 5 +
gdb/amd64-linux-nat.c | 19 +-
gdb/amd64-linux-tdep.c | 23 +-
gdb/amd64-linux-tdep.h | 5 +-
gdb/amd64-tdep.c | 80 +++++
gdb/amd64-tdep.h | 12 +-
gdb/common/i386-xstate.h | 20 +-
gdb/doc/gdb.texinfo | 34 +++
gdb/features/Makefile | 22 ++
gdb/features/i386/32bit-avx512.xml | 30 ++
gdb/features/i386/64bit-avx512.xml | 102 +++++++
gdb/features/i386/amd64-avx512-linux.c | 321 ++++++++++++++++++++
gdb/features/i386/amd64-avx512-linux.xml | 20 ++
gdb/features/i386/amd64-avx512.c | 316 ++++++++++++++++++++
gdb/features/i386/amd64-avx512.xml | 18 ++
gdb/features/i386/i386-avx512-linux.c | 208 +++++++++++++
gdb/features/i386/i386-avx512-linux.xml | 20 ++
gdb/features/i386/i386-avx512.c | 203 +++++++++++++
gdb/features/i386/i386-avx512.xml | 18 ++
gdb/features/i386/x32-avx512-linux.c | 321 ++++++++++++++++++++
gdb/features/i386/x32-avx512-linux.xml | 20 ++
gdb/features/i386/x32-avx512.c | 316 ++++++++++++++++++++
gdb/features/i386/x32-avx512.xml | 18 ++
gdb/gdbserver/Makefile.in | 19 +-
gdb/gdbserver/configure.srv | 20 +-
gdb/gdbserver/i387-fp.c | 182 ++++++++++-
gdb/gdbserver/linux-x86-low.c | 35 ++-
gdb/i386-linux-nat.c | 5 +-
gdb/i386-linux-tdep.c | 16 +-
gdb/i386-linux-tdep.h | 7 +-
gdb/i386-tdep.c | 465 +++++++++++++++++++++++++++--
gdb/i386-tdep.h | 64 +++-
gdb/i387-tdep.c | 384 +++++++++++++++++++++++-
gdb/i387-tdep.h | 21 ++
gdb/regformats/i386/amd64-avx512-linux.dat | 156 ++++++++++
gdb/regformats/i386/amd64-avx512.dat | 155 ++++++++++
gdb/regformats/i386/i386-avx512-linux.dat | 76 +++++
gdb/regformats/i386/i386-avx512.dat | 75 +++++
gdb/regformats/i386/x32-avx512-linux.dat | 156 ++++++++++
gdb/regformats/i386/x32-avx512.dat | 155 ++++++++++
gdb/testsuite/gdb.arch/Makefile.in | 2 +-
gdb/testsuite/gdb.arch/i386-avx512.c | 255 ++++++++++++++++
gdb/testsuite/gdb.arch/i386-avx512.exp | 177 +++++++++++
43 files changed, 4515 insertions(+), 61 deletions(-)
create mode 100644 gdb/features/i386/32bit-avx512.xml
create mode 100644 gdb/features/i386/64bit-avx512.xml
create mode 100644 gdb/features/i386/amd64-avx512-linux.c
create mode 100644 gdb/features/i386/amd64-avx512-linux.xml
create mode 100644 gdb/features/i386/amd64-avx512.c
create mode 100644 gdb/features/i386/amd64-avx512.xml
create mode 100644 gdb/features/i386/i386-avx512-linux.c
create mode 100644 gdb/features/i386/i386-avx512-linux.xml
create mode 100644 gdb/features/i386/i386-avx512.c
create mode 100644 gdb/features/i386/i386-avx512.xml
create mode 100644 gdb/features/i386/x32-avx512-linux.c
create mode 100644 gdb/features/i386/x32-avx512-linux.xml
create mode 100644 gdb/features/i386/x32-avx512.c
create mode 100644 gdb/features/i386/x32-avx512.xml
create mode 100644 gdb/regformats/i386/amd64-avx512-linux.dat
create mode 100644 gdb/regformats/i386/amd64-avx512.dat
create mode 100644 gdb/regformats/i386/i386-avx512-linux.dat
create mode 100644 gdb/regformats/i386/i386-avx512.dat
create mode 100644 gdb/regformats/i386/x32-avx512-linux.dat
create mode 100644 gdb/regformats/i386/x32-avx512.dat
create mode 100644 gdb/testsuite/gdb.arch/i386-avx512.c
create mode 100644 gdb/testsuite/gdb.arch/i386-avx512.exp

--
1.8.4.2