From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6908 invoked by alias); 13 Dec 2014 13:04:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6898 invoked by uid 89); 13 Dec 2014 13:04:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 13 Dec 2014 13:04:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D742711646B; Sat, 13 Dec 2014 08:04:28 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qgXjDcEkOhdi; Sat, 13 Dec 2014 08:04:28 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B8BA911646A; Sat, 13 Dec 2014 08:04:28 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 44E0A40164; Sat, 13 Dec 2014 08:04:29 -0500 (EST) Date: Sat, 13 Dec 2014 13:04:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: "mihail.nistor@freescale.com" , "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file Message-ID: <20141213130429.GA12185@adacore.com> References: <1410954786-17690-1-git-send-email-mihail.nistor@freescale.com> <542459B9.9090705@redhat.com> <23ca9e13576840e280392b69e5cc7de8@BN1PR0301MB0628.namprd03.prod.outlook.com> <7dec43bc41e044fcbba3289ca7cb2697@BN1PR0301MB0628.namprd03.prod.outlook.com> <542B0854.6050804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <542B0854.6050804@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00305.txt.bz2 > gdb/ChangeLog: > 2014-09-30 Keith Seitz > Mihail-Marian Nistor > > PR gdb/17394 > * linespec.c (struct collect_minsyms): Add new member `symtab'. > (add_minsym): Handle cases where info.symtab is non-NULL. > (search_minsyms_for_name): Add new parameter `symtab'. > Handle limiting searches to a specific symtab. > (add_matching_symtabs_to_info): Search through minimal symbols > for language_asm files for which no new symbols are found. > > gdb/testsuite/ChangeLog: > 2014-09-30 Mihail-Marian Nistor > > PR gdb/17394 > * gdb.linespec/break-asm-file.c: New file. > * gdb.linespec/break-asm-file.exp: New file. > * gdb.linespec/break-asm-file0.s: New file. > * gdb.linespec/break-asm-file1.s: New file. Overall, the patch looks good to me. Just a few trivial issues hightlighted below, but the patch is otherwise approved. > diff --git a/gdb/testsuite/gdb.linespec/break-asm-file.exp b/gdb/testsuite/gdb.linespec/break-asm-file.exp > + > +load_lib dwarf.exp Trailing space here... > diff --git a/gdb/testsuite/gdb.linespec/break-asm-file0.s b/gdb/testsuite/gdb.linespec/break-asm-file0.s [...] > @@ -0,0 +1,218 @@ > + .byte 1 /* DW_LNS_copy */ > + > + .byte 0 /* DW_LNE_set_address */ This file has a few .byte's where the formatting is inconsistent with the rest. Not critical, but would you mind fixing those? > + .byte 1 /* DW_LNS_copy */ > + Trailing spaces... > diff --git a/gdb/testsuite/gdb.linespec/break-asm-file1.s b/gdb/testsuite/gdb.linespec/break-asm-file1.s [...] > + .byte 1 /* DW_LNS_copy */ > + Trailing spaces again... > + .byte 1 /* DW_LNS_copy */ > + Ditto... > + .4byte .Lend_func > + ... and Ditto. Thank you, -- Joel