From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4720 invoked by alias); 8 Dec 2014 03:15:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4654 invoked by uid 89); 8 Dec 2014 03:15:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 08 Dec 2014 03:15:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A425B1163A1; Sun, 7 Dec 2014 22:14:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FQ1iEyENHMAp; Sun, 7 Dec 2014 22:14:58 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2FE00116364; Sun, 7 Dec 2014 22:14:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 875D846B66; Mon, 8 Dec 2014 07:14:51 +0400 (RET) Date: Mon, 08 Dec 2014 03:15:00 -0000 From: Joel Brobecker To: Chen Gang Cc: gdb-patches@sourceware.org, Andreas Schwab Subject: Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue Message-ID: <20141208031451.GK7899@adacore.com> References: <5447CF8A.6020603@gmail.com> <544AD714.8040506@gmail.com> <20141123063849.GA7636@adacore.com> <5471E3D5.10006@gmail.com> <5484D6EC.6080306@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5484D6EC.6080306@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00173.txt.bz2 > After consult parisc kernel members, I found the related document for > it, I guess, it can be as our proof for this patch: > > https://parisc.wiki.kernel.org/images-parisc/7/73/Parisc2.0.pdf > > For me, my original comments need be improved: need mention about STH, > and maybe also need consider about additional related instructions of > parisc 2.0 (STDA, STWA, STBY, STDBY) in our source code. > > Welcome any suggestions, ideas, and completions. OK - please send us an updated patch, and we will review. Thank you, -- Joel