Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch 0/2] Unify lookup_symbol_in_objfile_symtabs
Date: Wed, 03 Dec 2014 17:06:00 -0000	[thread overview]
Message-ID: <20141203170650.GA25020@host2.jankratochvil.net> (raw)

Hi,

I have seen
	[patchv3 2/2] Accelerate lookup_symbol_aux_objfile 85x
could be even applied in one other part of code which is duplicated now.

I am just not sure if we should go the route of
	struct objfile * -> const struct objfile *
or the other way of:
	const struct objfile * -> struct objfile *

Normally const adding is better but here I do not see much useful to have any
struct objfile * const and then it just causes pointer compatibility problems.

Please choose +const or -const variant for check-in.


Jan


             reply	other threads:[~2014-12-03 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 17:06 Jan Kratochvil [this message]
2014-12-03 17:18 ` Doug Evans
2014-12-03 17:36   ` Jan Kratochvil
2014-12-03 17:41     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203170650.GA25020@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox