From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10512 invoked by alias); 3 Dec 2014 10:12:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10500 invoked by uid 89); 3 Dec 2014 10:12:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 10:12:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6E67F116895; Wed, 3 Dec 2014 05:12:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tlbADgzt276T; Wed, 3 Dec 2014 05:12:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7A120116722; Wed, 3 Dec 2014 05:12:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6B52B46B66; Wed, 3 Dec 2014 14:12:18 +0400 (RET) Date: Wed, 03 Dec 2014 10:12:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Cleber Rosa , gdb-patches@sourceware.org, cleber@redhat.com Subject: Re: [PATCH 1/2] remote-utils.c: remove unused gdb_stdlog Message-ID: <20141203101218.GA7899@adacore.com> References: <1417449499-23681-1-git-send-email-crosa@redhat.com> <874mtfyuqq.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874mtfyuqq.fsf@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00055.txt.bz2 > > It looks like this came from an attempt to mimmic gdb/main.c, which > > has gdb_stdlog, gdb_stderr, gdb_stdout, etc. But in reality, it's > > not being used on gdbserver. > > Thanks for sending the patch upstream. As we have already discussed on > private, this looks almost obvious to me, but let's wait for some > maintainer to approve. Meanwhile... I agree the patch is obvious. But it's a good thing it wasn't pushed as such, considering the few little tweaks we can apply to make the submission the best we've had this year :-). More seriously, the patch is approved after Sergio's comments are resolved. And also please put the ChangeLog entry also in the revision log. Going one step further, we now tend to just "git send-email" the patch using the commit's revision log as the email subject and body. That way, we have the explanation for the patch in the revision log, which makes archeology a little easier. > > Signed-off-by: Cleber Rosa > > We don't use Signed-off-by here, but it shouldn't do any harm to keep it > in the patch. FWIW, agreed. It's not required, but acceptable as far as I am concerned (we haven't formally discussed this, but since it seems harmless to me, I don't see that it could be a problem). -- Joel