From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5483 invoked by alias); 3 Dec 2014 04:01:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5471 invoked by uid 89); 3 Dec 2014 04:01:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 04:01:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3CBB31163FD; Tue, 2 Dec 2014 23:01:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id btGP0LqEhOPv; Tue, 2 Dec 2014 23:01:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C3CFD116075; Tue, 2 Dec 2014 23:01:43 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8F8AC46B66; Wed, 3 Dec 2014 08:01:40 +0400 (RET) Date: Wed, 03 Dec 2014 04:01:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org, davem@redhat.com Subject: Re: [RFC/RFT] Use core regset iterators on Sparc Solaris Message-ID: <20141203040140.GL4882@adacore.com> References: <201411281548.sASFmPd9001359@d03av02.boulder.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201411281548.sASFmPd9001359@d03av02.boulder.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00053.txt.bz2 Hi Ulrich, > Sparc/Solaris is another native target still does not use the new-style > iterate_over_regset_sections core file logic (allowing cross-debugging > of core files and core file generation). > > Fortunately, it should be straightforward to enable to generic sparc logic > here by simply providing an appropriate register map. In fact, the map > itself is already present, and can just be reused. The only remaining > parameters needed are the total sizes of the register sections in core > files, which I've taken from public OpenSolaris sources. > > The patch is untested so far since I don't have access to a Sparc/Solaris > system. Testing by Solaris maintainers would be much appreciated. > > Bye, > Ulrich > > gdb/ > * config/sparc/sol2.mh (NATDEPFILES): Remove core-regset.o. > * sparc-sol2-tdep.c: Include "regset.h". > (sparc32_sol2_supply_core_gregset): New function. > (sparc32_sol2_collect_core_gregset): Likewise. > (sparc32_sol2_supply_core_fpregset): Likewise. > (sparc32_sol2_collect_core_fpregset): Likewise. > (sparc32_sol2_gregset, sparc32_sol2_fpregset): New variables. > (sparc32_sol2_init_abi): Set tdep->gregset/sizeof_gregset and > tdep->fpregset/sizeof_fpregset. > * sparc64-sol2-tdep.c: Include "regset.h". > (sparc64_sol2_supply_core_gregset): New function. > (sparc64_sol2_collect_core_gregset): Likewise. > (sparc64_sol2_supply_core_fpregset): Likewise. > (sparc64_sol2_collect_core_fpregset): Likewise. > (sparc64_sol2_gregset, sparc64_sol2_fpregset): New variables. > (sparc64_sol2_init_abi): Set tdep->gregset/sizeof_gregset and > tdep->fpregset/sizeof_fpregset. I will try to test your patch with AdaCore's testsuite, but currently, GDB does not build on Solaris, probably because of the gnulib update. I will try focusing on that first, and then do the testing. -- Joel