From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31844 invoked by alias); 28 Nov 2014 14:27:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31815 invoked by uid 89); 28 Nov 2014 14:27:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 28 Nov 2014 14:26:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 99973116690; Fri, 28 Nov 2014 09:26:57 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oiAhwk0syrZC; Fri, 28 Nov 2014 09:26:57 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 337F0116688; Fri, 28 Nov 2014 09:26:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EE4C040F79; Fri, 28 Nov 2014 18:26:53 +0400 (RET) Date: Fri, 28 Nov 2014 14:27:00 -0000 From: Joel Brobecker To: "H.J. Lu" Cc: GDB , Binutils Subject: Re: RFC: using AdaCore's git hooks for binutils-gdb.git ... Message-ID: <20141128142653.GI5042@adacore.com> References: <20141128135756.GK548@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00702.txt.bz2 > > - Allow the use of specific policies on a per-branch basis > > (ie - reject merges in release branches, for instance). > > > > Our scripts also correctly handle new references (new tags, new > > branches), as well as git notes. It is also Gerrit-ready, > > Does it handle removing a branch > > # git push origin :foo > > I used to get some extra messages. Yes, you get an email notifying you of the branch being deleted, and what commit the branch was pointing to before the removal of that branch. In addition, if any commits are "lost" (no longer accessible from any remaining branch or other reference), then a list of the commits that are no longer on any branch is included as well. Here is an example of what you'd get in the simple case: | From: Test Suite | To: git-hooks-ci@example.com | Subject: [repo] Deleted branch old-branch | X-Act-Checkin: repo | X-Git-Author: Test Suite | X-Git-Refname: refs/heads/old-branch | X-Git-Oldrev: cc8d2c2637bda27f0bc2125181dd2f8534d16222 | X-Git-Newrev: 0000000000000000000000000000000000000000 | | The branch 'old-branch' was deleted. | It previously pointed to: | | cc8d2c2... Modify `c', delete `b'. > Do we need to show the whole diff in the commit email? I think > a commit URL should be sufficient. Binutils-gdb commit > can have a very large commit diff due to generated files. No such option is available at the moment. Personally, I wouldn't like having a URL, at least not instead of a diff. I think having a diff is much more useful and immediate, as I use those as a chance to review post commit as well, or verify that what's committed is what was discussed on the list. But for large commits, there is a limit to the maximum size of the email, after which the email is truncated. -- Joel